* Input: atkbd - add forced release keys quirk for Samsung P560/P210
@ 2009-09-22 17:53 Jan-Michael Brummer
2009-09-22 18:46 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Jan-Michael Brummer @ 2009-09-22 17:53 UTC (permalink / raw)
To: dtor; +Cc: linux-input
This patch fixes the key repeat issue with the Fn+F? keys on the
Samsung P560 and P210 Notebook, so that the keys can used correctly,
otherwise the keys repeat indefinitely.
Signed-off-by: Jan-Michael Brummer <jan.brummer@tabos.org>
--- linux-source-2.6.31/drivers/input/keyboard/atkbd.c.orig 2009-09-16
02:23:02.000000000 +0200
+++ linux-source-2.6.31/drivers/input/keyboard/atkbd.c 2009-09-22
18:04:47.720622934 +0200
@@ -1607,6 +1607,24 @@ static struct dmi_system_id atkbd_dmi_qu
.driver_data = atkbd_samsung_forced_release_keys,
},
{
+ .ident = "Samsung P560",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "P560"),
+ },
+ .callback = atkbd_setup_forced_release,
+ .driver_data = atkbd_samsung_forced_release_keys,
+ },
+ {
+ .ident = "Samsung P210",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "P210"),
+ },
+ .callback = atkbd_setup_forced_release,
+ .driver_data = atkbd_samsung_forced_release_keys,
+ },
+ {
.ident = "Samsung SQ45S70S",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: Input: atkbd - add forced release keys quirk for Samsung P560/P210
2009-09-22 17:53 Input: atkbd - add forced release keys quirk for Samsung P560/P210 Jan-Michael Brummer
@ 2009-09-22 18:46 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2009-09-22 18:46 UTC (permalink / raw)
To: Jan-Michael Brummer; +Cc: linux-input
Hi Jan-Michael,
On Tue, Sep 22, 2009 at 07:53:33PM +0200, Jan-Michael Brummer wrote:
> This patch fixes the key repeat issue with the Fn+F? keys on the
> Samsung P560 and P210 Notebook, so that the keys can used correctly,
> otherwise the keys repeat indefinitely.
>
> Signed-off-by: Jan-Michael Brummer <jan.brummer@tabos.org>
Thank you for the patch, however I will not be accepting any more
patches adding the force-release quirks to atkbd, in .32 there will be a
way to adjust the bitmap through sysfs.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-09-22 18:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-22 17:53 Input: atkbd - add forced release keys quirk for Samsung P560/P210 Jan-Michael Brummer
2009-09-22 18:46 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).