From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 1/3] Input: DaVinci Key Scan Driver Date: Mon, 28 Sep 2009 10:02:32 -0700 Message-ID: <20090928170231.GD21455@core.coreip.homeip.net> References: <1253811202-21407-1-git-send-email-miguel.aguilar@ridgerun.com> <4ABCD1E8.5000200@ridgerun.com> <0554BEF07D437848AF01B9C9B5F0BC5D92C8EBC0@dlee01.ent.ti.com> <4ABCD78B.5050605@ridgerun.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from fg-out-1718.google.com ([72.14.220.159]:23386 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751329AbZI1RCd (ORCPT ); Mon, 28 Sep 2009 13:02:33 -0400 Received: by fg-out-1718.google.com with SMTP id 22so1529588fge.1 for ; Mon, 28 Sep 2009 10:02:37 -0700 (PDT) Content-Disposition: inline In-Reply-To: <4ABCD78B.5050605@ridgerun.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Miguel Aguilar Cc: "Paulraj, Sandeep" , "Nori, Sekhar" , "davinci-linux-open-source@linux.davincidsp.com" , "clark.becker@ridgerun.com" , "linux-input@vger.kernel.org" , "santiago.nunez@ridgerun.com" , "todd.fischer@ridgerun.com" On Fri, Sep 25, 2009 at 08:45:31AM -0600, Miguel Aguilar wrote: > >>>>>> + /* Enable Keyscan module and enable */ >>>>>> + davinci_ks_write(davinci_ks, DAVINCI_KEYSCAN_AUTODET | >>> DAVINCI_KEYSCAN_KEYEN, >>>>>> + DAVINCI_KEYSCAN_KEYCTRL); >>>>> We seem to be hardcoded to the 4x4 matrix type here. >>>>> Some DM365 boards could use 5x3 matrix. >>>>> >>>>> Thanks, >>>>> Sekhar >>>>> >>>> [MA] I will add a platform option for matrix type to choose 4x4 or 5x3 >>> matrix. >>>> What do think about this? >>>> >>> Sounds good. I am not sure if any other piece of code >>> needs to change though. >> The strobe and interval have to change. Afcourse that change comes into the picture only when the mode is changed from 4x4 to 5x3. >> I can see that there are options given for this in board specific code. >>> Thanks, >>> Sekhar >> >> Thanks, >> Sandeep >> > > struct davinci_ks_platform_data { > unsigned short *keymap; > u32 keymapsize; > u32 rep:1; > u32 strobe; > u32 interval; > + u32 matrix_type; > }; > > I will add something like this, so from the board specific code you can > define strobe, interval and matrix type. Make it enum at least. BTW, is it possible to add u8 rows, cols instead and be able to handle more matrix variations? -- Dmitry