From: Daniel Mack <daniel@caiaq.de>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] rotary_encoder: fix relative axis support
Date: Thu, 1 Oct 2009 11:25:48 +0200 [thread overview]
Message-ID: <20091001092548.GH9361@buzzloop.caiaq.de> (raw)
In-Reply-To: <BD79186B4FD85F4B8E60E381CAEE190901D42CBE@mi8nycmail19.Mi8.com>
On Wed, Sep 30, 2009 at 08:33:26PM -0400, H Hartley Sweeten wrote:
> When the rotart_encoder driver is used to report relative axis
> information the "steps" in the platform data could be missing
> since it's not relevant.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Daniel Mack <daniel@caiaq.de>
Acked-by: Daniel Mack <daniel@caiaq.de>
Thanks!
> ---
>
> diff --git a/drivers/input/misc/rotary_encoder.c b/drivers/input/misc/rotary_encoder.c
> index c806fbf..3b9f588 100644
> --- a/drivers/input/misc/rotary_encoder.c
> +++ b/drivers/input/misc/rotary_encoder.c
> @@ -106,8 +106,8 @@ static int __devinit rotary_encoder_probe(struct platform_device *pdev)
> struct input_dev *input;
> int err;
>
> - if (!pdata || !pdata->steps) {
> - dev_err(&pdev->dev, "invalid platform data\n");
> + if (!pdata) {
> + dev_err(&pdev->dev, "missing platform data\n");
> return -ENOENT;
> }
>
next prev parent reply other threads:[~2009-10-01 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 0:33 [PATCH] rotary_encoder: fix relative axis support H Hartley Sweeten
2009-10-01 9:25 ` Daniel Mack [this message]
2009-10-06 5:05 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091001092548.GH9361@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=hartleys@visionengravers.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).