From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jernej Turnsek <jernej.turnsek@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] Touchscreen driver for the DTS413
Date: Tue, 6 Oct 2009 21:36:13 -0700 [thread overview]
Message-ID: <20091007043613.GD10204@core.coreip.homeip.net> (raw)
In-Reply-To: <a57e67db0910060044g53ffd8a2s6db14c305bbf91df@mail.gmail.com>
On Tue, Oct 06, 2009 at 09:44:03AM +0200, Jernej Turnsek wrote:
> Hi,
>
> I would like to thank you for taking time to review DTS413 driver, but
> I am a little bit confused here. Regarding the comments I just
> followed a Ben Dooks suggestions, but I agree that internal functions
> shouldn't be commented in kernel doc style. Other thing is
> ABS_PRESSURE reporting. At first I thought that this is not
> neccessary, but when using driver with the Kdrive tiny X server
> (Xfbdev), it won't work. Xfbdev gives me Segmentation Fault.
That would be the issue with Xfbdev. There are plentry of touchscreen
driers in the kernel that do not report pressure.
--
Dmitry
prev parent reply other threads:[~2009-10-07 4:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a57e67db0909280023q7d352f22ge5b5343dc0c79c65@mail.gmail.com>
[not found] ` <4AC1DAA4.4090508@simtec.co.uk>
2009-09-29 12:00 ` [PATCH] Touchscreen driver for the DTS413 Jernej Turnsek
2009-09-29 12:14 ` Jernej Turnsek
2009-10-06 5:06 ` Dmitry Torokhov
2009-10-06 7:44 ` Jernej Turnsek
2009-10-07 4:36 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091007043613.GD10204@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=jernej.turnsek@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).