From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] Touchscreen driver for the DTS413 Date: Tue, 6 Oct 2009 21:36:13 -0700 Message-ID: <20091007043613.GD10204@core.coreip.homeip.net> References: <4AC1DAA4.4090508@simtec.co.uk> <20091006050640.GG27881@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-ew0-f217.google.com ([209.85.219.217]:55981 "EHLO mail-ew0-f217.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751026AbZJGEgb (ORCPT ); Wed, 7 Oct 2009 00:36:31 -0400 Received: by mail-ew0-f217.google.com with SMTP id 17so217414ewy.39 for ; Tue, 06 Oct 2009 21:36:19 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Jernej Turnsek Cc: linux-input@vger.kernel.org On Tue, Oct 06, 2009 at 09:44:03AM +0200, Jernej Turnsek wrote: > Hi, > > I would like to thank you for taking time to review DTS413 driver, but > I am a little bit confused here. Regarding the comments I just > followed a Ben Dooks suggestions, but I agree that internal functions > shouldn't be commented in kernel doc style. Other thing is > ABS_PRESSURE reporting. At first I thought that this is not > neccessary, but when using driver with the Kdrive tiny X server > (Xfbdev), it won't work. Xfbdev gives me Segmentation Fault. That would be the issue with Xfbdev. There are plentry of touchscreen driers in the kernel that do not report pressure. -- Dmitry