From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH] Haptic class support (v2) Date: Mon, 12 Oct 2009 07:40:23 -0700 Message-ID: <20091012144023.GB1239@kroah.com> References: <20091006074533.GA28889@july> <20091011090549.GE1414@ucw.cz> <9c9fda240910111732x262a9510rf3dd862aa16d0bdf@mail.gmail.com> <5d5443650910120644x4180ff6bt45b72be86b50588f@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from kroah.org ([198.145.64.141]:32846 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932321AbZJLOnp (ORCPT ); Mon, 12 Oct 2009 10:43:45 -0400 Content-Disposition: inline In-Reply-To: <5d5443650910120644x4180ff6bt45b72be86b50588f@mail.gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Trilok Soni Cc: Kyungmin Park , Pavel Machek , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org On Mon, Oct 12, 2009 at 07:14:57PM +0530, Trilok Soni wrote: > Hi Kyungmin, >=20 > On Mon, Oct 12, 2009 at 6:02 AM, Kyungmin Park = wrote: > > On Sun, Oct 11, 2009 at 6:05 PM, Pavel Machek wrote: > >> On Tue 2009-10-06 16:45:33, Kyungmin Park wrote: > >>> This patch includes two haptic devices, isa1000 and isa1200 > >>> ISA1000 is gpio based haptic, but isa1200 is based on I2C > >>> Both are working on Samsung SoCs and tested. > >>> > >>> To enable the haptic, echo 1 > /sys/class/haptic/${name}/enable > >>> You can adjust the level by echo ${level} > /sys/class/haptic/${n= ame}/enable > >>> or > >>> With oneshot feature, echo ${msec time} > /sys/class/haptic/${nam= e}/oneshot > >> > >> New device classes should certainly be documented in Documentation= /. > >> > >> For example... is level 0-100? > > > > Basically. range from 0 to 255. also each device can set max level = in > > case of isa1000 it's 6. > > > >> =A0Is it valid to change level while 'oneshot' is running? > > > > we usually use it under 1 sec. but I think it's possible to change = it > > but not tried. > > > >> =A0Does oneshot use last level set? > > > > Right. it used last set value. > > > > If you don't mind to update these at Documentation please wait unti= l > > commit first patches merged. >=20 > Let's see what Greg prefers. Could you please refresh your patchset > with probably addressing comments given in the isa1200 and samsung_pw= m > driver by me? Greg wants to see patches that add sysfs files to the kernel, also contain Documentation/ABI/ updates as well. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html