From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [REGRESSION] "bind" a device to a driver doesn't not work anymore Date: Mon, 12 Oct 2009 07:44:58 -0700 Message-ID: <20091012144458.GA1326@suse.de> References: <4AD120F2.3020606@tremplin-utc.net> <20091011030029.GA6526@suse.de> <200910112135.29384.dmitry.torokhov@gmail.com> <4AD31709.4000103@tremplin-utc.net> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from cantor.suse.de ([195.135.220.2]:47497 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932376AbZJLOs6 (ORCPT ); Mon, 12 Oct 2009 10:48:58 -0400 Content-Disposition: inline In-Reply-To: <4AD31709.4000103@tremplin-utc.net> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: =?iso-8859-1?Q?=C9ric?= Piel Cc: Dmitry Torokhov , Dmitry Torokhov , Linux Kernel Mailing List , linux-input@vger.kernel.org On Mon, Oct 12, 2009 at 01:46:17PM +0200, =C9ric Piel wrote: > Op 12-10-09 06:35, Dmitry Torokhov schreef: > > On Saturday 10 October 2009 08:00:29 pm Greg KH wrote: > >> On Sun, Oct 11, 2009 at 02:04:02AM +0200, ?ric Piel wrote: > >>> Hello, > >>> > >>> After a suspend, I used to do this (to get the PS2 keyboard worki= ng > >>> again), and it used to work fine: > >>> echo -n "i8042" > /sys/bus/platform/drivers/i8042/unbind ; sleep = 1 ; echo > >>> -n "i8042" > /sys/bus/platform/drivers/i8042/bind > >>> > >>> Unfortunately since 2.6.32-rc1, the unbind works fine, but the bi= nd > >>> returns a "no such device" error now (and the binding is not done= ). After > >>> that, additional unbinds also report the error. I think 2.6.31 wo= rked > >>> fine. Any idea what's going wrong? > >> Odd. Any chance you can run 'git bisect' to figure out which patc= h > >> might have caused it? > >=20 > > I8042 has been converted to use platform_driver_probe() - we are cr= eating=20 > > platform device and platform driver together, there is no chance th= at some=20 > > other device might be driven by i8042 driver. > I haven't finished bisecting, but indeed, the problem seemed to conve= rge > toward this patch. >=20 >=20 > > Eric, do you still need to fiddle with i8042 to get your keyboard w= orking with=20 > > 2.6.32-rc3? We need to make sure that resube works without users ne= eding to=20 > > mess with bind/unbind. > Yes, the keyboard doesn't work after the first resume from ram (the > later resumes do work). I haven't tried any special option to the i80= 42 > driver. This is on a HP 2510, in 64 bits. >=20 > Indeed, it would be great to fix this root problem! Is there any bug > report opened to work on this? >=20 > However, currently the first problem is that unbind works, while bind > doesn't. Which means anyone doing an unbind will have keyboard and mo= use > lost until the next reboot. That's rather bad because it has been > recommended for a long time to have this kind of script at resume: > http://intertrusion.com/files/hp-s2ram.patch > http://en.opensuse.org/Pm-utils >=20 > So at least, unbind should fail as well as bind. Ah, I bet I know why bind fails... Yeah, the i8042_platform_device is never freed up in the i8042_remove() function in drivers/input/serio/i8042.c, so when you try to register it again, it fails. Dmitry, care to fix this up? Should be pretty simple. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html