From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: miguel.aguilar@ridgerun.com
Cc: davinci-linux-open-source@linux.davincidsp.com,
nsnehaprabha@ti.com, linux-input@vger.kernel.org,
todd.fischer@ridgerun.com, diego.dompe@ridgerun.com,
clark.becker@ridgerun.com, santiago.nunez@ridgerun.com
Subject: Re: [PATCH v5 1/2] Input: DaVinci Keypad Driver
Date: Tue, 13 Oct 2009 11:13:02 -0700 [thread overview]
Message-ID: <20091013181301.GB21593@core.coreip.homeip.net> (raw)
In-Reply-To: <1255454163-22179-1-git-send-email-miguel.aguilar@ridgerun.com>
Miguel,
On Tue, Oct 13, 2009 at 11:16:03AM -0600, miguel.aguilar@ridgerun.com wrote:
> From: Miguel Aguilar <miguel.aguilar@ridgerun.com>
>
> Adds the driver for enabling keypad support for DaVinci platforms.
>
> DM365 is the only platform that uses this driver at the moment.
>
Could you please also get rid of davinci_ks_{read,write} - they are
pointless. I promise this is my last request ;)
Also - I wonder who "owns" board-specific code (the one your second
patch is affecting). I usually let arch people to merge it instead of
goping thruogh input tree.
--
Dmitry
next prev parent reply other threads:[~2009-10-13 18:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-13 17:16 [PATCH v5 1/2] Input: DaVinci Keypad Driver miguel.aguilar-9uBrGCPFOa1Wk0Htik3J/w
2009-10-13 18:13 ` Dmitry Torokhov [this message]
[not found] ` <20091013181301.GB21593-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2009-10-13 18:59 ` Miguel Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091013181301.GB21593@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=clark.becker@ridgerun.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=diego.dompe@ridgerun.com \
--cc=linux-input@vger.kernel.org \
--cc=miguel.aguilar@ridgerun.com \
--cc=nsnehaprabha@ti.com \
--cc=santiago.nunez@ridgerun.com \
--cc=todd.fischer@ridgerun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).