[PATCH 0/1] Open / close for polled input device

[PATCH 0/1] Open / close for polled input device

[Samu Onkalo]

Small sensors could utilise polled input device. Sometimes there is
a need to prepare or close the HW. This patch adds optional 
open / close functionality to the polled input device driver.

Samu Onkalo (1):
  Polled input device: add device open and close methods

 drivers/input/input-polldev.c |    6 ++++++
 include/linux/input-polldev.h |    2 ++
 2 files changed, 8 insertions(+), 0 deletions(-)

[PATCH 1/1] Polled input device: add device open and close methods

[Samu Onkalo]

Optional open and close methods for preparing and closing
the device.

Signed-off-by: Samu Onkalo <samu.p.onkalo@nokia.com>
---
 drivers/input/input-polldev.c |    6 ++++++
 include/linux/input-polldev.h |    2 ++
 2 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/input/input-polldev.c b/drivers/input/input-polldev.c
index 0d3ce7a..0ad788b 100644
--- a/drivers/input/input-polldev.c
+++ b/drivers/input/input-polldev.c
@@ -80,6 +80,9 @@ static int input_open_polled_device(struct input_dev *input)
 	if (error)
 		return error;
 
+	if (dev->open)
+		dev->open(dev);
+
 	if (dev->flush)
 		dev->flush(dev);
 
@@ -95,6 +98,9 @@ static void input_close_polled_device(struct input_dev *input)
 
 	cancel_delayed_work_sync(&dev->work);
 	input_polldev_stop_workqueue();
+
+	if (dev->close)
+		dev->close(dev);
 }
 
 /**
diff --git a/include/linux/input-polldev.h b/include/linux/input-polldev.h
index 597a007..ba266c1 100644
--- a/include/linux/input-polldev.h
+++ b/include/linux/input-polldev.h
@@ -30,6 +30,8 @@
 struct input_polled_dev {
 	void *private;
 
+	void (*open)(struct input_polled_dev *dev);
+	void (*close)(struct input_polled_dev *dev);
 	void (*flush)(struct input_polled_dev *dev);
 	void (*poll)(struct input_polled_dev *dev);
 	unsigned int poll_interval; /* msec */
-- 
1.5.6.3

Re: [PATCH 1/1] Polled input device: add device open and close methods

[Dmitry Torokhov]

On Tue, Oct 13, 2009 at 09:24:48AM +0300, Samu Onkalo wrote:
> Optional open and close methods for preparing and closing
> the device.
> 
> Signed-off-by: Samu Onkalo <samu.p.onkalo@nokia.com>
> ---
>  drivers/input/input-polldev.c |    6 ++++++
>  include/linux/input-polldev.h |    2 ++
>  2 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/input/input-polldev.c b/drivers/input/input-polldev.c
> index 0d3ce7a..0ad788b 100644
> --- a/drivers/input/input-polldev.c
> +++ b/drivers/input/input-polldev.c
> @@ -80,6 +80,9 @@ static int input_open_polled_device(struct input_dev *input)
>  	if (error)
>  		return error;
>  
> +	if (dev->open)
> +		dev->open(dev);
> +
>  	if (dev->flush)
>  		dev->flush(dev);

Hmm... I think having both open and flush is overkill. My fault for not
looking closer, I will kill the flush and convert existing users to
open.

-- 
Dmitry

RE: [PATCH 1/1] Polled input device: add device open and close methods

[samu.p.onkalo]

 >input_dev *input)
>>  	if (error)
>>  		return error;
>>  
>> +	if (dev->open)
>> +		dev->open(dev);
>> +
>>  	if (dev->flush)
>>  		dev->flush(dev);
>
>Hmm... I think having both open and flush is overkill. My 
>fault for not looking closer, I will kill the flush and 
>convert existing users to open.
>

Good. So I can continue work with my drivers with an assumption that
there are open and close methods available at some point.

Samu