From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: linux-input@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] hp_sdc_rtc: Fix test in hp_sdc_rtc_read_rt()
Date: Sun, 18 Oct 2009 00:19:33 -0700 [thread overview]
Message-ID: <20091018071933.GD3935@core.coreip.homeip.net> (raw)
In-Reply-To: <4AD89B77.6070303@gmail.com>
On Fri, Oct 16, 2009 at 06:12:39PM +0200, Roel Kluin wrote:
> If left unsigned the hp_sdc_rtc_read_i8042timer() return value will not
> be checked correctly.
>
Applied, thank you Roel.
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/drivers/input/misc/hp_sdc_rtc.c b/drivers/input/misc/hp_sdc_rtc.c
> index 216a559..ea821b5 100644
> --- a/drivers/input/misc/hp_sdc_rtc.c
> +++ b/drivers/input/misc/hp_sdc_rtc.c
> @@ -209,7 +209,7 @@ static inline int hp_sdc_rtc_read_rt(struct timeval *res) {
>
> /* Read the i8042 fast handshake timer */
> static inline int hp_sdc_rtc_read_fhs(struct timeval *res) {
> - uint64_t raw;
> + int64_t raw;
> unsigned int tenms;
>
> raw = hp_sdc_rtc_read_i8042timer(HP_SDC_CMD_LOAD_FHS, 2);
--
Dmitry
prev parent reply other threads:[~2009-10-18 7:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-16 16:12 [PATCH] hp_sdc_rtc: Fix test in hp_sdc_rtc_read_rt() Roel Kluin
2009-10-18 7:19 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091018071933.GD3935@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-input@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).