From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Daniel Mack <daniel@caiaq.de>
Cc: Richard Purdie <rpurdie@rpsys.net>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
Constantin Baranov <const@mimas.ru>
Subject: Re: [PATCH] leds-alix2: add support for button connected to J15
Date: Mon, 19 Oct 2009 18:38:53 -0700 [thread overview]
Message-ID: <20091020013852.GC24370@core.coreip.homeip.net> (raw)
In-Reply-To: <20091019073728.GC28832@buzzloop.caiaq.de>
Hi Daniel,
On Mon, Oct 19, 2009 at 09:37:28AM +0200, Daniel Mack wrote:
> +#else
> +#define alix_button_register() (0)
> +#endif
> +
> static int __init alix_led_probe(struct platform_device *pdev)
> {
> int i;
> @@ -89,6 +139,11 @@ static int __init alix_led_probe(struct platform_device *pdev)
> if (ret < 0)
> goto fail;
> }
> +
> + ret = alix_button_register();
> + if (ret)
> + goto fail;
> +
> return 0;
>
> fail:
> @@ -103,6 +158,10 @@ static int alix_led_remove(struct platform_device *pdev)
>
> for (i = 0; i < ARRAY_SIZE(alix_leds); i++)
> led_classdev_unregister(&alix_leds[i].cdev);
> +
> + if (ipdev)
> + input_unregister_polled_device(ipdev);
> +
I think it will bomb on !CONFIG_LEDS_ALIX2_BUTTON... You need
alix_button_register() and a dummy wrapper for it as well.
--
Dmitry
next prev parent reply other threads:[~2009-10-20 1:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-16 13:03 [PATCH] leds-alix2: add support for button connected to J15 Daniel Mack
2009-10-18 7:27 ` Dmitry Torokhov
2009-10-19 7:37 ` Daniel Mack
2009-10-20 1:38 ` Dmitry Torokhov [this message]
2009-10-20 10:13 ` Daniel Mack
2009-10-21 4:35 ` Dmitry Torokhov
2009-10-21 19:33 ` Daniel Mack
2009-10-21 20:21 ` Constantin Baranov
2009-10-21 20:41 ` Daniel Mack
2009-10-21 21:39 ` Constantin Baranov
2009-10-21 22:09 ` Constantin Baranov
2009-10-22 10:11 ` Daniel Mack
2009-10-18 10:56 ` Richard Purdie
2009-10-19 7:16 ` Daniel Mack
2009-10-22 10:29 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091020013852.GC24370@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=const@mimas.ru \
--cc=daniel@caiaq.de \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).