Re: [PATCH] leds-alix2: add support for button connected to J15

[Constantin Baranov <const@mimas.ru>]

Hi, Daniel!

I wonder why do you integrate the input driver into the leds driver. They
should be separated. Or at least the complex driver should be moved to the
"X86 Platform Specific Device Drivers" and renamed to some like "PC Engines
ALIX Extras". I personally would prefer the separation way.

Also ALIX.2 documentation describes the "Mode switch" driven by GPIO which is a
small button on front side of a board. I guessed your driver is not for this
button. If so, would it be better to provide the mode switch as KEY_PROG1 and
the J15 connected button as KEY_PROG2 at once?

Cheers,
Constantin

> From 66953e5dda7bbbc22b92541ed3a6020773c62140 Mon Sep 17 00:00:00 2001
> From: Daniel Mack <daniel@caiaq.de>
> Date: Tue, 13 Oct 2009 12:42:52 +0800
> Subject: [PATCH] leds-alix2: add support for button connected to J15
> 
> The ALIX2 boards have one GPIO pin which is reachable at connector J15.
> One possible application for this feature is to connect a button which
> closes the two pins.
> 
> This patch adds support to query these button and export its state via
> an input device.
> 
> Signed-off-by: Daniel Mack <daniel@caiaq.de>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> Cc: linux-input@vger.kernel.org
> Cc: Constantin Baranov <const@mimas.ru>