From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [REPOST] [PATCH] Add support for OQO 01+ multimedia keys (fwd) Date: Wed, 21 Oct 2009 23:52:42 -0700 Message-ID: <20091022065242.GA13036@core.coreip.homeip.net> References: <20091020013859.GD24370@core.coreip.homeip.net> <20091021044936.GA386@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-px0-f179.google.com ([209.85.216.179]:33009 "EHLO mail-px0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753456AbZJVGwn (ORCPT ); Thu, 22 Oct 2009 02:52:43 -0400 Received: by pxi9 with SMTP id 9so3201146pxi.4 for ; Wed, 21 Oct 2009 23:52:48 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Jamie Lentin Cc: linux-input@vger.kernel.org On Wed, Oct 21, 2009 at 07:15:54PM +0100, Jamie Lentin wrote: > On Tue, 20 Oct 2009, Dmitry Torokhov wrote: >> On Tue, Oct 20, 2009 at 09:12:38PM +0100, Jamie Lentin wrote: >>> On Mon, 19 Oct 2009, Dmitry Torokhov wrote: >>> >>>> On Tue, Jun 30, 2009 at 11:06:49PM +0100, Jamie Lentin wrote: >>>>> Apologies for reposting, but it'd be nice to get something along these >>>>> lines merged. If there's suggestions of other things I could try, or >>>>> you'd prefer a patch to make the "up" and "down" keycodes auto-release, >>>>> please let me know. >>>>> >>>> >>>> I am sorry, I completely missed your patch and just now was going >>>> through my inbox and saw it... >>> >>> Not to worry---so long as the patch wasn't so offensive you couldn't bring >>> yourself to reply :) >> >> ;) >> >>> >>>> Could you please tell me if OQO has external PS/2 port? >>> >>> No, it has a PS/2 trackpoint and gravity mouse (easter-egg mode where the >>> firmware turns accelerometer input into mouse) built-in, but I doubt >>> they'll provide much useful info. >>> >> >> OK, I was just concerned about the scancode mangling screwing up >> external keyboard but in absence of PS/2 ports this point is moot. >> >> I rearranged the code a bit, could yo please try it out to make sure I >> did not screw it up and I will apply it. > > Tried it, works fine. Applying this would be much appreciated! > Applied, thank you Jamie. it will be in mainline next time Linus pulls from my tree. -- Dmitry