Patch to fix Volume keys on AMILO 1848+u (Kernel 2.6.32-rc5)

Patch to fix Volume keys on AMILO 1848+u (Kernel 2.6.32-rc5)

[Pascal Bach]

The Fn+F7 and Fn+F8 Keys to change the Volume don't work as the don't  
send a key release event.

The patch I appended adds the Amilo 1848+u to the special handling  
list of the atkbd.c driver.

The patch is for 2.6.32-rc5.

--- atkbd.c.orig	2009-10-26 11:23:07.000000000 +0100
+++ atkbd.c	2009-10-26 11:24:03.000000000 +0100
@@ -901,6 +901,13 @@ static unsigned int atkbd_amilo_pi3525_f
  };

  /*
+ * Amilo Si 1848 key release for Fn+Volume keys not working
+ */
+static unsigned int atkbd_amilo_si1848_forced_release_keys[] = {
+	0xa0, 0xae, 0xb0, -1U
+};
+
+/*
   * Amilo Xi 3650 key release for light touch bar not working
   */
  static unsigned int atkbd_amilo_xi3650_forced_release_keys[] = {
@@ -1637,6 +1644,15 @@ static struct dmi_system_id atkbd_dmi_qu
  		.driver_data = atkbd_volume_forced_release_keys,
  	},
  	{
+		.ident = "Fujitsu Amilo Si 1848+u",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "AMILO Si 1848+u"),
+		},
+		.callback = atkbd_setup_forced_release,
+		.driver_data = atkbd_amilo_si1848_forced_release_keys,
+	},
+	{
  		.ident = "Fujitsu Amilo Pi 3525",
  		.matches = {
  			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),

Re: Patch to fix Volume keys on AMILO 1848+u (Kernel 2.6.32-rc5)

[Dmitry Torokhov]

Hi Pascal,

On Mon, Oct 26, 2009 at 11:35:04AM +0100, Pascal Bach wrote:
> The Fn+F7 and Fn+F8 Keys to change the Volume don't work as the don't  
> send a key release event.
>
> The patch I appended adds the Amilo 1848+u to the special handling list 
> of the atkbd.c driver.
>

Thank you for the patch, however since atkbd now allows controlling the
force release bitmap from userspace (via sysfs) I have stopped accepting
kernel quirks and instead ask people to rely on HAL/DeviceKit or some
other userspace solution.

Thanks.

-- 
Dmitry