linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Young <hidave.darkstar@gmail.com>
To: dmitry.torokhov@gmail.com
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH][RFC] input: remove bios I8042_CTR_XLATE check to make keyboard usable
Date: Tue, 27 Oct 2009 13:34:04 +0800	[thread overview]
Message-ID: <20091027053404.GA2241@darkstar.vlan7> (raw)


Pressing somekey at early booting phase cause keyboard to be not usable
(The hardware is DELL latitude e5400):

atkbd.c: Unknown key pressed (raw set 2, code 0xd3 on isa0060/serio0).
atkbd.c: Use 'setkeycodes e053 <keycode>' to make it known.
atkbd.c: Unknown key pressed (raw set 2, code 0x1d3 on isa0060/serio0).
atkbd.c: Use 'setkeycodes e053 <keycode>' to make it known.

i8042.c set i8042_direct to true when the controller init. But the result
is keyboard not usable, The only option is press the power button to shutdown. 

So here remove the bios check to fix it.

Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
---
 drivers/input/serio/i8042.c |    8 --------
 1 file changed, 8 deletions(-)

--- linux-2.6.orig/drivers/input/serio/i8042.c	2009-10-13 08:57:07.000000000 +0800
+++ linux-2.6/drivers/input/serio/i8042.c	2009-10-27 13:15:13.000000000 +0800
@@ -869,14 +869,6 @@ static int i8042_controller_init(void)
 	spin_unlock_irqrestore(&i8042_lock, flags);
 
 /*
- * If the chip is configured into nontranslated mode by the BIOS, don't
- * bother enabling translating and be happy.
- */
-
-	if (~i8042_ctr & I8042_CTR_XLATE)
-		i8042_direct = true;
-
-/*
  * Set nontranslated mode for the kbd interface if requested by an option.
  * After this the kbd interface becomes a simple serial in/out, like the aux
  * interface is. We don't do this by default, since it can confuse notebook

             reply	other threads:[~2009-10-27  5:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-27  5:34 Dave Young [this message]
2009-10-28  5:43 ` [PATCH][RFC] input: remove bios I8042_CTR_XLATE check to make keyboard usable Dmitry Torokhov
2009-10-28 10:03   ` Vojtech Pavlik
2009-10-28 10:42     ` Dave Young
2009-10-29  0:33       ` Dave Young
2009-10-29  3:26         ` Dmitry Torokhov
2009-10-29  7:15           ` Dave Young
2009-11-01  8:33             ` Dave Young
2009-11-02  7:47               ` Dmitry Torokhov
2009-11-02 10:49                 ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091027053404.GA2241@darkstar.vlan7 \
    --to=hidave.darkstar@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).