From: Arjan van de Ven <arjan@infradead.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Anssi Hannula <anssi.hannula@gmail.com>,
Jussi Kivilinna <jussi.kivilinna@mbnet.fi>,
linux-input@vger.kernel.org
Subject: Re: [PATCH] input: fix locking context in ml_ff_set_gain
Date: Mon, 2 Nov 2009 21:53:58 -0800 [thread overview]
Message-ID: <20091102215358.5398c8c1@infradead.org> (raw)
In-Reply-To: <20091103054446.GB3212@core.coreip.homeip.net>
>
> OK, it ended up being pretty simple. Anssi, any chance you could test
> it to make sure I did not screw up? Thanks!
>
@@ -371,35 +370,34 @@ static void ml_effect_timer(unsigned long
timer_data)
debug("timer: updating effects");
- spin_lock(&ml->timer_lock);
+ spin_lock_irq(&dev->event_lock);
ml_play_effects(ml);
- spin_unlock(&ml->timer_lock);
+ spin_unlock_irq(&dev->event_lock);
}
this bit looks evil.
might be better off as irqsave...
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2009-11-03 5:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-31 21:19 [PATCH] input: fix locking context in ml_ff_set_gain Arjan van de Ven
2009-11-02 6:38 ` Dmitry Torokhov
2009-11-03 5:44 ` Dmitry Torokhov
2009-11-03 5:53 ` Arjan van de Ven [this message]
2009-11-03 5:59 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091102215358.5398c8c1@infradead.org \
--to=arjan@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=anssi.hannula@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jussi.kivilinna@mbnet.fi \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).