* [PATCH] Input: Remove unneeded '\n' from psmouse.proto parameter
@ 2009-11-13 7:22 Takashi Iwai
2009-11-13 7:31 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Takashi Iwai @ 2009-11-13 7:22 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input
The get parameter function should return a string without a life-feed.
Otherwise you'll see additional empty line in sysfs parameters file.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
drivers/input/mouse/psmouse-base.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/input/mouse/psmouse-base.c b/drivers/input/mouse/psmouse-base.c
index 690aed9..5bd6484 100644
--- a/drivers/input/mouse/psmouse-base.c
+++ b/drivers/input/mouse/psmouse-base.c
@@ -1673,7 +1673,7 @@ static int psmouse_get_maxproto(char *buffer, struct kernel_param *kp)
{
int type = *((unsigned int *)kp->arg);
- return sprintf(buffer, "%s\n", psmouse_protocol_by_type(type)->name);
+ return sprintf(buffer, "%s", psmouse_protocol_by_type(type)->name);
}
static int __init psmouse_init(void)
--
1.6.4.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: Remove unneeded '\n' from psmouse.proto parameter
2009-11-13 7:22 [PATCH] Input: Remove unneeded '\n' from psmouse.proto parameter Takashi Iwai
@ 2009-11-13 7:31 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2009-11-13 7:31 UTC (permalink / raw)
To: Takashi Iwai; +Cc: linux-input
On Fri, Nov 13, 2009 at 08:22:52AM +0100, Takashi Iwai wrote:
> The get parameter function should return a string without a life-feed.
> Otherwise you'll see additional empty line in sysfs parameters file.
>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Applied, thank you Takashi.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-13 7:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-13 7:22 [PATCH] Input: Remove unneeded '\n' from psmouse.proto parameter Takashi Iwai
2009-11-13 7:31 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).