From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Johannes Stezenbach <js@sig21.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jiri Kosina <jkosina@suse.cz>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: atkbd - add forced release kays quirk for Samsung N130
Date: Tue, 17 Nov 2009 21:16:05 -0800 [thread overview]
Message-ID: <20091118051605.GA31480@core.coreip.homeip.net> (raw)
In-Reply-To: <20091116213425.GA2128@sig21.net>
On Mon, Nov 16, 2009 at 10:34:25PM +0100, Johannes Stezenbach wrote:
> Hi Dmitry,
>
> On Mon, Nov 16, 2009 at 11:54:43AM -0800, Dmitry Torokhov wrote:
> > On Mon, Nov 16, 2009 at 06:18:14PM +0100, Johannes Stezenbach wrote:
> > > Samsung N130 has the same function key quirks as the NC10.
> > >
> > > Signed-off-by: Johannes Stezenbach <js@sig21.net>
> > > ---
> > > It would be nice if this could go into 2.6.32. It might also be
> > > suitable for stable.
> >
> > 2.6.32 will allow manipulating force release quirk from userspace
> > (sysfs) so I stopped accepting in-kernel quirks like this one.
>
> OK, makes sense. Will this be put in udev along with
> the keymap setup for the function keys?
I think that is the best place to put it, yes.
> If yes, is
> there already an example how to do it correctly so
> I can submit a patch to add the N130 support there?
No, but you can be the first and pave the road ;)
--
Dmitry
prev parent reply other threads:[~2009-11-18 5:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-16 17:18 [PATCH] input: atkbd - add forced release kays quirk for Samsung N130 Johannes Stezenbach
2009-11-16 19:54 ` Dmitry Torokhov
2009-11-16 21:34 ` Johannes Stezenbach
2009-11-18 5:16 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091118051605.GA31480@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jkosina@suse.cz \
--cc=js@sig21.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).