[PATCH] input: atkbd - add forced release kays quirk for Samsung N130

[PATCH] input: atkbd - add forced release kays quirk for Samsung N130

[Johannes Stezenbach]

Samsung N130 has the same function key quirks as the NC10.

Signed-off-by: Johannes Stezenbach <js@sig21.net>
---
It would be nice if this could go into 2.6.32.  It might also be
suitable for stable.


diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
index 4452eab..ad2dc7d 100644
--- a/drivers/input/keyboard/atkbd.c
+++ b/drivers/input/keyboard/atkbd.c
@@ -1646,6 +1646,15 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
 		.driver_data = atkbd_samsung_forced_release_keys,
 	},
 	{
+		.ident = "Samsung N130",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "N130"),
+		},
+		.callback = atkbd_setup_forced_release,
+		.driver_data = atkbd_samsung_forced_release_keys,
+	},
+	{
 		.ident = "Samsung SQ45S70S",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),

Re: [PATCH] input: atkbd - add forced release kays quirk for Samsung N130

[Dmitry Torokhov]

Hi Johannes,

On Mon, Nov 16, 2009 at 06:18:14PM +0100, Johannes Stezenbach wrote:
> Samsung N130 has the same function key quirks as the NC10.
> 
> Signed-off-by: Johannes Stezenbach <js@sig21.net>
> ---
> It would be nice if this could go into 2.6.32.  It might also be
> suitable for stable.

2.6.32 will allow manipulating force release quirk from userspace
(sysfs) so I stopped accepting in-kernel quirks like this one.

Thanks.

-- 
Dmitry

Re: [PATCH] input: atkbd - add forced release kays quirk for Samsung N130

[Johannes Stezenbach]

Hi Dmitry,

On Mon, Nov 16, 2009 at 11:54:43AM -0800, Dmitry Torokhov wrote:
> On Mon, Nov 16, 2009 at 06:18:14PM +0100, Johannes Stezenbach wrote:
> > Samsung N130 has the same function key quirks as the NC10.
> > 
> > Signed-off-by: Johannes Stezenbach <js@sig21.net>
> > ---
> > It would be nice if this could go into 2.6.32.  It might also be
> > suitable for stable.
> 
> 2.6.32 will allow manipulating force release quirk from userspace
> (sysfs) so I stopped accepting in-kernel quirks like this one.

OK, makes sense.  Will this be put in udev along with
the keymap setup for the function keys?  If yes, is
there already an example how to do it correctly so 
I can submit a patch to add the N130 support there?


Thanks
Johannes

Re: [PATCH] input: atkbd - add forced release kays quirk for Samsung N130

[Dmitry Torokhov]

On Mon, Nov 16, 2009 at 10:34:25PM +0100, Johannes Stezenbach wrote:
> Hi Dmitry,
> 
> On Mon, Nov 16, 2009 at 11:54:43AM -0800, Dmitry Torokhov wrote:
> > On Mon, Nov 16, 2009 at 06:18:14PM +0100, Johannes Stezenbach wrote:
> > > Samsung N130 has the same function key quirks as the NC10.
> > > 
> > > Signed-off-by: Johannes Stezenbach <js@sig21.net>
> > > ---
> > > It would be nice if this could go into 2.6.32.  It might also be
> > > suitable for stable.
> > 
> > 2.6.32 will allow manipulating force release quirk from userspace
> > (sysfs) so I stopped accepting in-kernel quirks like this one.
> 
> OK, makes sense.  Will this be put in udev along with
> the keymap setup for the function keys? 

I think that is the best place to put it, yes.

> If yes, is
> there already an example how to do it correctly so 
> I can submit a patch to add the N130 support there?

No, but you can be the first and pave the road ;)

-- 
Dmitry