Re: [PATCH] hx4700: fix hx4700 touchscreen pressure values

Re: [PATCH] hx4700: fix hx4700 touchscreen pressure values

[Pavel Machek]

On Wed 2009-11-18 00:22:41, Paul Parsons wrote:
> > Does pressure actually work as expected -- that is not inverted?
> > Because I need this patch on spitz...  but it may break your
> > machine...
> 
> You are right, the pressure values were being inverted on my hx4700.
> Pressing hard generates somewhat lower Rt values than pressing lightly.
> 
> Since typical hx4700 Rt values are close to (pressure_max/2) anyway,
> the inverted and non-inverted values were not very different.
> For example:
> 
> Rt      ts->pressure_max-Rt
> 599     425
> 562     462
> 588     436
> 570     454
> 
> So by all means submit your ads7846.c patch; it will not break hx4700.

Dmitry, those pressure values are reverted on more than one machine,
and we do not have anyone reporting it works ok for them. Can we
perhaps just.... fix it?
								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [PATCH] hx4700: fix hx4700 touchscreen pressure values

[Dmitry Torokhov]

On Wed, Nov 18, 2009 at 06:28:49PM +0100, Pavel Machek wrote:
> On Wed 2009-11-18 00:22:41, Paul Parsons wrote:
> > > Does pressure actually work as expected -- that is not inverted?
> > > Because I need this patch on spitz...  but it may break your
> > > machine...
> > 
> > You are right, the pressure values were being inverted on my hx4700.
> > Pressing hard generates somewhat lower Rt values than pressing lightly.
> > 
> > Since typical hx4700 Rt values are close to (pressure_max/2) anyway,
> > the inverted and non-inverted values were not very different.
> > For example:
> > 
> > Rt      ts->pressure_max-Rt
> > 599     425
> > 562     462
> > 588     436
> > 570     454
> > 
> > So by all means submit your ads7846.c patch; it will not break hx4700.
> 
> Dmitry, those pressure values are reverted on more than one machine,
> and we do not have anyone reporting it works ok for them. Can we
> perhaps just.... fix it?

OK, so we have 4 instances where pressure is inverted and nobody wants
to come out with a non-inverted example... I'll queue for .33 then - .32
it too close to the release.

-- 
Dmitry

Re: [PATCH] hx4700: fix hx4700 touchscreen pressure values

[Dmitry Torokhov]

On Wed, Nov 18, 2009 at 09:39:34AM -0800, Dmitry Torokhov wrote:
> On Wed, Nov 18, 2009 at 06:28:49PM +0100, Pavel Machek wrote:
> > On Wed 2009-11-18 00:22:41, Paul Parsons wrote:
> > > > Does pressure actually work as expected -- that is not inverted?
> > > > Because I need this patch on spitz...  but it may break your
> > > > machine...
> > > 
> > > You are right, the pressure values were being inverted on my hx4700.
> > > Pressing hard generates somewhat lower Rt values than pressing lightly.
> > > 
> > > Since typical hx4700 Rt values are close to (pressure_max/2) anyway,
> > > the inverted and non-inverted values were not very different.
> > > For example:
> > > 
> > > Rt      ts->pressure_max-Rt
> > > 599     425
> > > 562     462
> > > 588     436
> > > 570     454
> > > 
> > > So by all means submit your ads7846.c patch; it will not break hx4700.
> > 
> > Dmitry, those pressure values are reverted on more than one machine,
> > and we do not have anyone reporting it works ok for them. Can we
> > perhaps just.... fix it?
> 
> OK, so we have 4 instances where pressure is inverted and nobody wants
> to come out with a non-inverted example... I'll queue for .33 then - .32
> it too close to the release.
> 

Btw, could you send me the latest version of your patch please?

-- 
Dmitry

Re: [PATCH] hx4700: fix hx4700 touchscreen pressure values

[Pavel Machek]

> > > Dmitry, those pressure values are reverted on more than one machine,
> > > and we do not have anyone reporting it works ok for them. Can we
> > > perhaps just.... fix it?
> > 
> > OK, so we have 4 instances where pressure is inverted and nobody wants
> > to come out with a non-inverted example... I'll queue for .33 then - .32
> > it too close to the release.
> > 
> 
> Btw, could you send me the latest version of your patch please?

Yep, resent in separate mail.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html