From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Gregoire Gentil <gregoire@gentil.com>
Cc: linux-omap@vger.kernel.org, linux-input@vger.kernel.org,
Tony Lindgren <tony@atomide.com>, Tim Yamin <plasmaroo@gmail.com>
Subject: Re: [PATCH 5/8] AI TB: HID file for Always Innovating OMAP3-based Touch Book keyboard
Date: Wed, 18 Nov 2009 22:30:41 -0800 [thread overview]
Message-ID: <20091119063040.GA3010@core.coreip.homeip.net> (raw)
In-Reply-To: <1258599474.8001.36.camel@gregoire-laptop>
Hi Gregoire,
On Wed, Nov 18, 2009 at 06:57:54PM -0800, Gregoire Gentil wrote:
> +
> +int touchbook_create_sysfs(struct hid_device *hdev)
> +{
> + int i;
> + int r;
> +
> + for (i = 0; i < ARRAY_SIZE(touchbook_hid_attrs); i++) {
> + r = device_create_file(&hdev->dev,
> + &touchbook_hid_attrs[i]);
> +
> + if (r) {
> + dev_err(&hdev->dev, "failed to create sysfs file\n");
> + return r;
> + }
> + }
> +
You just reimplemented sysfs attribute group.
--
Dmitry
prev parent reply other threads:[~2009-11-19 6:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1258228079.16065.17.camel@runt>
[not found] ` <1258345850.9089.21.camel@gregoire-laptop>
2009-11-19 2:57 ` [PATCH 4/8] AI TB: Driver for Always Innovating OMAP3-based Touch Book keyboard Gregoire Gentil
2009-11-19 2:57 ` [PATCH 5/8] AI TB: HID file " Gregoire Gentil
2009-11-19 6:30 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091119063040.GA3010@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=gregoire@gentil.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=plasmaroo@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).