From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 1/2] Input: gpio-keys: allow drivers to specify whether IRQ can be shared Date: Fri, 20 Nov 2009 00:38:17 -0800 Message-ID: <20091120083817.GB3009@core.coreip.homeip.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pw0-f42.google.com ([209.85.160.42]:46830 "EHLO mail-pw0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752588AbZKTIiP (ORCPT ); Fri, 20 Nov 2009 03:38:15 -0500 Received: by pwi3 with SMTP id 3so1958354pwi.21 for ; Fri, 20 Nov 2009 00:38:21 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Mika Westerberg Cc: linux-input@vger.kernel.org Hi Mika, On Thu, Nov 19, 2009 at 09:23:45AM +0200, Mika Westerberg wrote: > Added new field to struct gpio_keys_button: exclusive_irq which can > be used to specify whether driver wants to have exclusive access to > IRQ or can it be shared. By default IRQs for gpio-keys are shareable. > I think the idea makes sense with one exception - why limit just to sharing and not let platform specify the exact IRQ flags it needs, defaulting to IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_SHARED? -- Dmitry