* Re: [PATCH] hx4700: fix hx4700 touchscreen pressure values [not found] <E1NAYJo-00016g-PW@pih-relay04.plus.net> @ 2009-11-18 17:28 ` Pavel Machek 2009-11-18 17:39 ` Dmitry Torokhov 0 siblings, 1 reply; 4+ messages in thread From: Pavel Machek @ 2009-11-18 17:28 UTC (permalink / raw) To: Paul Parsons, dtor, dmitry.torokhov, linux-input Cc: rpurdie, lenz, linux-kernel, Dirk, arminlitzel, metan, thommycheck, linux-arm-kernel, dbaryshkov, omegamoon, eric.y.miao, utx On Wed 2009-11-18 00:22:41, Paul Parsons wrote: > > Does pressure actually work as expected -- that is not inverted? > > Because I need this patch on spitz... but it may break your > > machine... > > You are right, the pressure values were being inverted on my hx4700. > Pressing hard generates somewhat lower Rt values than pressing lightly. > > Since typical hx4700 Rt values are close to (pressure_max/2) anyway, > the inverted and non-inverted values were not very different. > For example: > > Rt ts->pressure_max-Rt > 599 425 > 562 462 > 588 436 > 570 454 > > So by all means submit your ads7846.c patch; it will not break hx4700. Dmitry, those pressure values are reverted on more than one machine, and we do not have anyone reporting it works ok for them. Can we perhaps just.... fix it? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hx4700: fix hx4700 touchscreen pressure values 2009-11-18 17:28 ` [PATCH] hx4700: fix hx4700 touchscreen pressure values Pavel Machek @ 2009-11-18 17:39 ` Dmitry Torokhov 2009-11-18 17:46 ` Dmitry Torokhov 0 siblings, 1 reply; 4+ messages in thread From: Dmitry Torokhov @ 2009-11-18 17:39 UTC (permalink / raw) To: Pavel Machek Cc: Paul Parsons, linux-input, rpurdie, lenz, linux-kernel, Dirk, arminlitzel, metan, thommycheck, linux-arm-kernel, dbaryshkov, omegamoon, eric.y.miao, utx On Wed, Nov 18, 2009 at 06:28:49PM +0100, Pavel Machek wrote: > On Wed 2009-11-18 00:22:41, Paul Parsons wrote: > > > Does pressure actually work as expected -- that is not inverted? > > > Because I need this patch on spitz... but it may break your > > > machine... > > > > You are right, the pressure values were being inverted on my hx4700. > > Pressing hard generates somewhat lower Rt values than pressing lightly. > > > > Since typical hx4700 Rt values are close to (pressure_max/2) anyway, > > the inverted and non-inverted values were not very different. > > For example: > > > > Rt ts->pressure_max-Rt > > 599 425 > > 562 462 > > 588 436 > > 570 454 > > > > So by all means submit your ads7846.c patch; it will not break hx4700. > > Dmitry, those pressure values are reverted on more than one machine, > and we do not have anyone reporting it works ok for them. Can we > perhaps just.... fix it? OK, so we have 4 instances where pressure is inverted and nobody wants to come out with a non-inverted example... I'll queue for .33 then - .32 it too close to the release. -- Dmitry ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hx4700: fix hx4700 touchscreen pressure values 2009-11-18 17:39 ` Dmitry Torokhov @ 2009-11-18 17:46 ` Dmitry Torokhov 2009-11-20 18:24 ` Pavel Machek 0 siblings, 1 reply; 4+ messages in thread From: Dmitry Torokhov @ 2009-11-18 17:46 UTC (permalink / raw) To: Pavel Machek Cc: Paul Parsons, linux-input, rpurdie, lenz, linux-kernel, Dirk, arminlitzel, metan, thommycheck, linux-arm-kernel, dbaryshkov, omegamoon, eric.y.miao, utx On Wed, Nov 18, 2009 at 09:39:34AM -0800, Dmitry Torokhov wrote: > On Wed, Nov 18, 2009 at 06:28:49PM +0100, Pavel Machek wrote: > > On Wed 2009-11-18 00:22:41, Paul Parsons wrote: > > > > Does pressure actually work as expected -- that is not inverted? > > > > Because I need this patch on spitz... but it may break your > > > > machine... > > > > > > You are right, the pressure values were being inverted on my hx4700. > > > Pressing hard generates somewhat lower Rt values than pressing lightly. > > > > > > Since typical hx4700 Rt values are close to (pressure_max/2) anyway, > > > the inverted and non-inverted values were not very different. > > > For example: > > > > > > Rt ts->pressure_max-Rt > > > 599 425 > > > 562 462 > > > 588 436 > > > 570 454 > > > > > > So by all means submit your ads7846.c patch; it will not break hx4700. > > > > Dmitry, those pressure values are reverted on more than one machine, > > and we do not have anyone reporting it works ok for them. Can we > > perhaps just.... fix it? > > OK, so we have 4 instances where pressure is inverted and nobody wants > to come out with a non-inverted example... I'll queue for .33 then - .32 > it too close to the release. > Btw, could you send me the latest version of your patch please? -- Dmitry ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hx4700: fix hx4700 touchscreen pressure values 2009-11-18 17:46 ` Dmitry Torokhov @ 2009-11-20 18:24 ` Pavel Machek 0 siblings, 0 replies; 4+ messages in thread From: Pavel Machek @ 2009-11-20 18:24 UTC (permalink / raw) To: Dmitry Torokhov Cc: Paul Parsons, linux-input, rpurdie, lenz, linux-kernel, Dirk, arminlitzel, metan, thommycheck, linux-arm-kernel, dbaryshkov, omegamoon, eric.y.miao, utx > > > Dmitry, those pressure values are reverted on more than one machine, > > > and we do not have anyone reporting it works ok for them. Can we > > > perhaps just.... fix it? > > > > OK, so we have 4 instances where pressure is inverted and nobody wants > > to come out with a non-inverted example... I'll queue for .33 then - .32 > > it too close to the release. > > > > Btw, could you send me the latest version of your patch please? Yep, resent in separate mail. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-11-20 18:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1NAYJo-00016g-PW@pih-relay04.plus.net>
2009-11-18 17:28 ` [PATCH] hx4700: fix hx4700 touchscreen pressure values Pavel Machek
2009-11-18 17:39 ` Dmitry Torokhov
2009-11-18 17:46 ` Dmitry Torokhov
2009-11-20 18:24 ` Pavel Machek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).