From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Oliver Neukum <oliver@neukum.org>
Cc: linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
Ondrej Zary <linux@rainbow-software.org>,
Jiri Kosina <jkosina@suse.cz>, Daniel Ritz <daniel.ritz@gmx.ch>
Subject: Re: [patch]race between disconnect and open in usbtouchscreen
Date: Mon, 23 Nov 2009 09:21:33 -0800 [thread overview]
Message-ID: <20091123172133.GA17813@core.coreip.homeip.net> (raw)
In-Reply-To: <200911202249.56591.oliver@neukum.org>
On Fri, Nov 20, 2009 at 10:49:56PM +0100, Oliver Neukum wrote:
> Am Freitag, 20. November 2009 22:22:59 schrieb Dmitry Torokhov:
> > Hi Oliver,
> >
> > On Fri, Nov 20, 2009 at 10:13:47PM +0100, Oliver Neukum wrote:
> > > Hi,
> > >
> > > an open() between killing the urb and unregistering the device
> > > can lead to IO to a disconnected device.
> >
> > usbtouch_close() calls usb_kill_urb() so there is no race.
> > usb_kill_urb() simply not needed in usbtouch_disconnect().
>
> Then it needs to go.
>
Applied, thank you Oliver.
--
Dmitry
prev parent reply other threads:[~2009-11-23 17:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 21:13 [patch]race between disconnect and open in usbtouchscreen Oliver Neukum
2009-11-20 21:22 ` Dmitry Torokhov
2009-11-20 21:49 ` Oliver Neukum
2009-11-23 17:21 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091123172133.GA17813@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=daniel.ritz@gmx.ch \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).