From: Ralf Baechle <ralf@linux-mips.org>
To: Wu Zhangjin <wuzhangjin@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-mips@linux-mips.org, zhangfx@lemote.com, yanh@lemote.com,
huhb@lemote.com, linux-input@vger.kernel.org
Subject: Re: [PATCH v5 8/8] Loongson: YeeLoong: add hotkey driver
Date: Sun, 29 Nov 2009 07:29:48 +0000 [thread overview]
Message-ID: <20091129072948.GA15146@linux-mips.org> (raw)
In-Reply-To: <1259473802.2577.6.camel@falcon.domain.org>
On Sun, Nov 29, 2009 at 01:50:02PM +0800, Wu Zhangjin wrote:
> On Sat, 2009-11-28 at 21:35 -0800, Dmitry Torokhov wrote:
> > On Sat, Nov 28, 2009 at 09:44:41PM +0800, Wu Zhangjin wrote:
> > >
> > > +config YEELOONG_HOTKEY
> > > + tristate "Hotkey Driver"
> > > + depends on YEELOONG_VO
> > > + select INPUT
> >
> > I think this should be depend, not select.
>
> Hmm, okay, will replace it by depend later ;)
>
> >
> > > + select INPUT_EVDEV
> > > + select SUSPEND
> >
> > Does it break without SUSPEND?
>
> not break, but I just want to select something for users, so, they will
> have no need to care about which extra option is needed.
We use select extensively on MIPS but select is dangerous and you stepped
into its trap. When SUSPEND is enabled by a user in
kernel/power/Kconfig it can only be choosen if PM is enabled. By
"select SUSPEND" this dependency so now it is possible to have a kernel
where SUSPEND is enabled without PM which won't work.
Ralf
next prev parent reply other threads:[~2009-11-29 7:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1259414649.git.wuzhangjin@gmail.com>
2009-11-28 13:44 ` [PATCH v5 8/8] Loongson: YeeLoong: add hotkey driver Wu Zhangjin
2009-11-29 5:35 ` Dmitry Torokhov
2009-11-29 5:50 ` Wu Zhangjin
2009-11-29 7:29 ` Ralf Baechle [this message]
2009-11-29 7:40 ` Wu Zhangjin
2009-11-30 5:18 ` Wu Zhangjin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091129072948.GA15146@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=dmitry.torokhov@gmail.com \
--cc=huhb@lemote.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=wuzhangjin@gmail.com \
--cc=yanh@lemote.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).