From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Anisse Astier <anisse@astier.eu>
Cc: linux-input@vger.kernel.org, linux-acpi@vger.kernel.org,
Len Brown <lenb@kernel.org>,
Carlos Corbacho <carlos@strangeworlds.co.uk>
Subject: Re: [RFC PATCH 2/2] Input: msi-wmi - switch to using sparse keymap library
Date: Wed, 2 Dec 2009 10:48:42 -0800 [thread overview]
Message-ID: <20091202184842.GB20530@core.coreip.homeip.net> (raw)
In-Reply-To: <20091202192812.7e9919fb@destiny.ordissimo>
On Wed, Dec 02, 2009 at 07:28:12PM +0100, Anisse Astier wrote:
>
> static void __exit msi_wmi_exit(void)
Anisse,
It does not look like you are freeing sparse keymap when you
unnregistering input device, otherwise looks good.
--
Dmitry
next prev parent reply other threads:[~2009-12-02 18:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 18:26 [RFC PATCH 1/2] Input: add msi-wmi driver to support hotkeys in MSI Windtop AE1900-WT Anisse Astier
2009-12-02 18:28 ` [RFC PATCH 2/2] Input: msi-wmi - switch to using sparse keymap library Anisse Astier
2009-12-02 18:48 ` Dmitry Torokhov [this message]
2009-12-03 3:11 ` [RFC PATCH 1/2] Input: add msi-wmi driver to support hotkeys in MSI Windtop AE1900-WT Dmitry Torokhov
2009-12-03 9:08 ` Anisse Astier
2009-12-03 9:34 ` Dmitry Torokhov
2009-12-03 16:49 ` Thomas Renninger
2009-12-04 10:15 ` Anisse Astier
2009-12-04 10:55 ` Thomas Renninger
2009-12-04 13:51 ` Anisse Astier
2009-12-04 15:20 ` Thomas Renninger
2009-12-04 15:35 ` Anisse Astier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091202184842.GB20530@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=anisse@astier.eu \
--cc=carlos@strangeworlds.co.uk \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).