Re: [PATCH 32/33] input: add KEY_WIRELESS_CYCLE

[Matthew Garrett <mjg59@srcf.ucam.org>]

On Mon, Dec 07, 2009 at 11:23:34AM -0200, Henrique de Moraes Holschuh wrote:
> On Mon, 07 Dec 2009, Matthew Garrett wrote:
> > On Mon, Dec 07, 2009 at 09:47:49AM -0200, Henrique de Moraes Holschuh wrote:
> > > What I do know, is that I will miss a keycode that rfkills just my WLAN... I
> > > use that for power management, it is nice to have a key that is for WLAN
> > > only, and another that is for bluetooth-only...
> > 
> > KEY_WLAN will still be there, and you can still remap. But the default 
> > behaviour should be for thinkpad-acpi (for instance) to generate 
> > KEY_RFKILL, since Fn+F5 isn't supposed to be wlan only.
> 
> That's not what I got from this thread.  What I got was that KEY_WLAN would
> be overloaded with KEY_RFKILL semanthics, regardless of anything we did in
> the kernel side.

No.

> I am strongly with you here: add a *new* KEY_RFKILL, fix the kernel drivers
> and any eventual userspace to use the new KEY_RFKILL, and have KEY_WLAN do
> what it is supposed to do.

Right. That's what the patch I sent does.

> And, if what we call KEY_WLAN is actually supposed to be KEY_RFKILL, swap
> their definitions when adding KEY_RFKILL, so that USB HID devices will
> generate KEY_RFKILL instead of KEY_WLAN.

I don't think this is in HID?

-- 
Matthew Garrett | mjg59@srcf.ucam.org