From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] ep93xx_keypad.c: update driver to new core support
Date: Wed, 9 Dec 2009 19:11:30 -0800 [thread overview]
Message-ID: <20091210031130.GG10138@core.coreip.homeip.net> (raw)
In-Reply-To: <BD79186B4FD85F4B8E60E381CAEE190901FB0DB6@mi8nycmail19.Mi8.com>
On Wed, Dec 09, 2009 at 05:20:53PM -0500, H Hartley Sweeten wrote:
> ep93xx_keypad.c: update driver to new core support
>
> This driver was merged before the ep93xx core support was added
> for the keypad clock and acquiring/releasing the necessary gpio's.
> Now that the proper support is in the ep93xx core this driver
> needs to be updated to work correctly.
>
> Summary of changes:
> 1) Remove some unused members from the platform data.
> 2) Remove the custom KEY macro and use the ones available in
> <linux/input/matrix_keypad.h>
> 3) Remove the keypad_{readl/writel} macros and just use
> __raw_{readl/writel} directly.
> 4) Update the clk_set_rate() call to work with the core support.
> 5) Cleanup the probe routine and remove some unneeded messages.
> 6) Use the ep93xx core functions to acquire and release the gpio's.
> 7) Fix the clk_get() call to get the keypad clock.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Thank you Hartley. I will change 'enabled' to bool while we are at it
and apply for the next pull.
--
Dmitry
next prev parent reply other threads:[~2009-12-10 3:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 22:20 [PATCH] ep93xx_keypad.c: update driver to new core support H Hartley Sweeten
2009-12-10 3:11 ` Dmitry Torokhov [this message]
2009-12-10 16:34 ` H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091210031130.GG10138@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=hartleys@visionengravers.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).