linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Peter Hutterer <peter.hutterer@who-t.net>
Cc: "Stéphane Chatty" <chatty@enac.fr>,
	linux-input@vger.kernel.org, "Rafi Rubin" <rafi@seas.upenn.edu>,
	"Benjamin Tissoires" <tissoire@cena.fr>
Subject: Re: [PATCH 2/2] Support for Stantum multitouch panel
Date: Thu, 10 Dec 2009 23:52:39 -0800	[thread overview]
Message-ID: <20091211075238.GA30274@core.coreip.homeip.net> (raw)
In-Reply-To: <20091211005831.GI13607@barra.bne.redhat.com>

On Fri, Dec 11, 2009 at 10:58:31AM +1000, Peter Hutterer wrote:
> On Thu, Dec 10, 2009 at 04:47:20PM -0800, Dmitry Torokhov wrote:
> > On Fri, Dec 11, 2009 at 10:35:04AM +1000, Peter Hutterer wrote:
> > > On Thu, Dec 10, 2009 at 04:19:22PM -0800, Dmitry Torokhov wrote:
> > > > > are we talking about kernel drivers or userspace drivers here?
> > > > > 
> > > > > not handling ABS_MT_X, ABS_MT_Y properly in evdev is a bug (well,
> > > > > not-yet-implemented feature) but if the kernel hands out both ABS_X and
> > > > > ABS_MT_X that makes it difficult to determine which event is a valid one and
> > > > > which one can be ignored.
> > > > > 
> > > > 
> > > > No, it is pretty simple - all events are valid, otherwise it is kernel
> > > > driver bug. Now, as userspace consumer, if you know how to handle
> > > > multitouch protocol then use it, ignore ABS_X/ABS_Y. Otherwise you'd be
> > > > dropping ABS_MT_* events and naturally handling ABS_X/ABS_Y.
> > > 
> > > Thanks, that's the answer I hoped for - if ABS_MT_X is available, we can
> > > ignore ABS_X.
> > > 
> > > The tricky part would have been if both were equally valid _at the same
> > > time_ but refer to different inputs. at which point you'd have to find out
> > > which one to map to which pointer axis, etc. We already have a problem with
> > > REL_X and ABS_X on the same device, adding the ABS_MT_X to that mess
> > > wouldn't have helped the situation.
> > 
> > What devices report both ABS_X and REL_X events?
> 
> Xen Virtual Pointer
> AlpsPS/2 ALPS GlidePoint

Hmm, ALPS should not be reporting REL_X/REL_Y on touchpad device, only
on the secondary device. I will fix it, thank you for the report.

-- 
Dmitry

  reply	other threads:[~2009-12-11  7:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-09 21:49 [PATCH 2/2] Support for Stantum multitouch panel Stephane Chatty
2009-12-09 23:15 ` Dmitry Torokhov
2009-12-10  7:37   ` Stéphane Chatty
2009-12-10 18:28     ` Dmitry Torokhov
2009-12-10 19:28       ` Rafi Rubin
2009-12-10 23:21         ` Peter Hutterer
2009-12-11  0:15         ` Dmitry Torokhov
2009-12-11  0:03       ` Peter Hutterer
2009-12-11  0:19         ` Dmitry Torokhov
2009-12-11  0:35           ` Peter Hutterer
2009-12-11  0:47             ` Dmitry Torokhov
2009-12-11  0:58               ` Peter Hutterer
2009-12-11  7:52                 ` Dmitry Torokhov [this message]
2009-12-23 10:56   ` Stephane Chatty
2010-01-04 11:03     ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091211075238.GA30274@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=chatty@enac.fr \
    --cc=linux-input@vger.kernel.org \
    --cc=peter.hutterer@who-t.net \
    --cc=rafi@seas.upenn.edu \
    --cc=tissoire@cena.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).