From: Alex Chiang <achiang@hp.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-input@vger.kernel.org
Subject: Re: synaptics touchpad doesn't click
Date: Tue, 15 Dec 2009 23:52:00 -0700	[thread overview]
Message-ID: <20091216065200.GC20352@ldl.fc.hp.com> (raw)
In-Reply-To: <20091216025934.GA2699@core.coreip.homeip.net>
* Dmitry Torokhov <dmitry.torokhov@gmail.com>:
> On Tue, Dec 15, 2009 at 06:05:06PM -0700, Alex Chiang wrote:
> > * Dmitry Torokhov <dmitry.torokhov@gmail.com>:
> > >
> > > The updated patch is below.
> > > 
> > > -- 
> > > Dmitry
> > 
> > Should I test this one or wait one more iteration to address
> > Takashi's last comments?
> > 
> 
> Actually I think we took the wrong direction with the original patch and
> we should do what other buttonless devices (bcm5974) do: report touchpad
> click as left button and have Synaptics X driver provide enhanced
> support. This way we can have both modes (ClickZones and ClickButtons)
> and users will get to chose (provided that someone takes time to add
> that support to Synaptics driver of course ;) ).
> 
> Could you tell me if the below works for you?
Left clicks work. Right/middle do not (as expected, I guess).
I liked the behaviour of Takashi's patch a little better wrt what
happens when you try to click/drag, because he disabled movement
in the click area.
My vodka consumption is minimal and I don't have the shakes, but
I found it difficult to precisely hit the edge of a window and
click / drag to resize...
/ac
next prev parent reply	other threads:[~2009-12-16  6:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20091214014828.GA28402@ldl.fc.hp.com>
     [not found] ` <20091214173450.GB2373@core.coreip.homeip.net>
2009-12-15  3:41   ` synaptics touchpad doesn't click Alex Chiang
2009-12-15  6:26     ` Dmitry Torokhov
2009-12-15  6:40       ` Takashi Iwai
2009-12-15  7:33         ` Dmitry Torokhov
2009-12-15  7:41           ` Takashi Iwai
2009-12-15  8:25             ` Dmitry Torokhov
2009-12-15 10:19               ` Takashi Iwai
2009-12-15 10:41               ` Takashi Iwai
2009-12-16  1:05               ` Alex Chiang
2009-12-16  2:59                 ` Dmitry Torokhov
2009-12-16  6:50                   ` Takashi Iwai
2009-12-16  6:56                     ` Dmitry Torokhov
2009-12-16  7:14                       ` Takashi Iwai
2009-12-16  8:23                         ` Dmitry Torokhov
2009-12-16  9:17                           ` Takashi Iwai
2009-12-16 17:24                             ` Dmitry Torokhov
2009-12-16 17:32                               ` Takashi Iwai
2009-12-16  7:16                     ` Takashi Iwai
2009-12-16  6:52                   ` Alex Chiang [this message]
2009-12-16  7:03                     ` Dmitry Torokhov
2009-12-16  7:11                       ` Takashi Iwai
2009-12-16  8:20                         ` Dmitry Torokhov
2009-12-16  9:14                           ` Takashi Iwai
2009-12-16 17:31                       ` Alex Chiang
2009-12-16 17:42                         ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=20091216065200.GC20352@ldl.fc.hp.com \
    --to=achiang@hp.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).