From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Bastian Blank <waldi@debian.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Ping Cheng <pingc@wacom.com>
Subject: Re: [PATCH 2/7] Input: wacom - Get features from driver info
Date: Thu, 7 Jan 2010 11:39:50 -0800 [thread overview]
Message-ID: <201001071139.50766.dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20100107192105.GA15015@wavehammer.waldi.eu.org>
On Thursday 07 January 2010 11:21:05 am Bastian Blank wrote:
> On Thu, Jan 07, 2010 at 11:06:30AM -0800, Dmitry Torokhov wrote:
> > On Thursday 07 January 2010 10:29:36 am Bastian Blank wrote:
> > > + struct wacom_features *features = (void *)id->driver_info;
> >
> > What is this cast for?
>
> driver_info is an integer.
>
> > > + if (!features)
> > > + features = get_wacom_feature(id);
> >
> > In which cases driver would not have driver_info set up?
>
> At this stage in the patchset, non have. Later the driver defined ids
> have, the user defined have not.
>
Ah, OK. Frankly I would fold patches 2-7 into one since it is one logical
change. While you are at it, any chance of constifying wacom_features?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2010-01-07 19:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 18:25 [PATCH 0/7] Input: wacom - Setup features via driver info Bastian Blank
2010-01-07 18:29 ` [PATCH 1/7] Input: wacom - Move device ids to the initialisation Bastian Blank
2010-01-07 18:29 ` [PATCH 2/7] Input: wacom - Get features from driver info Bastian Blank
2010-01-07 19:06 ` Dmitry Torokhov
2010-01-07 19:21 ` Bastian Blank
2010-01-07 19:39 ` Dmitry Torokhov [this message]
2010-01-07 18:29 ` [PATCH 3/7] Input: wacom - Set driver info for Wacom Penpartner Bastian Blank
2010-01-07 18:29 ` [PATCH 4/7] Input: wacom - Convert remaining ids, part one Bastian Blank
2010-01-07 18:29 ` [PATCH 5/7] Input: wacom - Convert remaining ids, part two Bastian Blank
2010-01-11 21:22 ` Ping Cheng
2010-01-11 22:24 ` Bastian Blank
2010-02-03 8:47 ` Dmitry Torokhov
[not found] ` <bc07448c1002030634m2c8492a4h9dc1c1ad005bc98f@mail.gmail.com>
2010-02-03 17:28 ` Dmitry Torokhov
2010-01-07 18:30 ` [PATCH 6/7] Imput: wacom - Remove old feature struct setup Bastian Blank
2010-01-07 18:30 ` [PATCH 7/7] Input: wacom - Fail on missing features Bastian Blank
2010-01-07 19:08 ` Dmitry Torokhov
2010-01-07 19:21 ` Bastian Blank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001071139.50766.dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pingc@wacom.com \
--cc=waldi@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).