From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 5/7] Input: wacom - Convert remaining ids, part two Date: Wed, 3 Feb 2010 09:28:47 -0800 Message-ID: <20100203172846.GA30600@core.coreip.homeip.net> References: <20100107182553.GA11236@wavehammer.waldi.eu.org> <20100107182953.GA12985@wavehammer.waldi.eu.org> <6753EB6004AFF34FAA275742C104F952016A1329@wacom-nt10.wacom.com> <20100111222448.GA7959@wavehammer.waldi.eu.org> <20100203084725.GB22110@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Jason Childs Cc: Ping Cheng , Bastian Blank , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-input@vger.kernel.org Jason, On Wed, Feb 03, 2010 at 09:34:09AM -0500, Jason Childs wrote: > Dmitry, > > I actually responded on this issue to Ping last night. My argument is that > the usb_driver structure is subject to revision on a per kernel basis and > should be in wacom_sys.c. 100% agree, and that is why usb_driver continues to stay in wacom_sys. Wacom product IDs however are hardly linux-specific, usb_device_id is unlikely to be changed significantly (since there are userspace ties) and thus make sense to be kept in wacom_wac.c > Also with the new set of bamboo patches the > features structures are copied per device instance during the initial probe > so we are not breaking static conventions. Ah, great. So nothing stops you guys from marking these statics const - I can't do it till your changes reach me. Speaking of which, the next merge window is getting close so now would be the best time to send your pending queue towars me. *wink, wink* Thanks. -- Dmitry