From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 1/1] media: dvb-usb/af9015, fix disconnection crashes Date: Thu, 4 Feb 2010 10:41:32 -0800 Message-ID: <20100204184132.GD10965@core.coreip.homeip.net> References: <1264007972-6261-1-git-send-email-jslaby@suse.cz> <4B5CDB53.6030009@iki.fi> <4B5D6098.7010700@gmail.com> <4B5DDDFB.5020907@iki.fi> <4B6AA211.1060707@gmail.com> <20100204181404.GC10965@core.coreip.homeip.net> <4B6B12F2.2080102@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-bw0-f219.google.com ([209.85.218.219]:39665 "EHLO mail-bw0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757319Ab0BDSlq (ORCPT ); Thu, 4 Feb 2010 13:41:46 -0500 Content-Disposition: inline In-Reply-To: <4B6B12F2.2080102@gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Jiri Slaby Cc: Jiri Kosina , Antti Palosaari , mchehab@infradead.org, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org, Pekka Sarnila , linux-input@vger.kernel.org On Thu, Feb 04, 2010 at 07:33:22PM +0100, Jiri Slaby wrote: > On 02/04/2010 07:14 PM, Dmitry Torokhov wrote: > > On Thu, Feb 04, 2010 at 11:31:45AM +0100, Jiri Slaby wrote: > > + > >> +static int dvb_event(struct hid_device *hdev, struct hid_field *field, > >> + struct hid_usage *usage, __s32 value) > >> +{ > >> + /* we won't get a "key up" event */ > >> + if (value) { > >> + input_event(field->hidinput->input, usage->type, usage->code, 1); > >> + input_event(field->hidinput->input, usage->type, usage->code, 0); > > > > Do not ever forget input_sync(), you need 2 of them here. > > > > With the latest changes to evdev, if you are using SIGIO you won't get > > wioken up until EV_SYN/SYN_REPORT. > > HID layer syncs on its own. So the second is not needed. Why is needed > the first? > Userpsace has a right to accumulate events and only act on them when receiving EV_SYN. Press + release in the same event block may be treated as no change. The same as REL_X +2, REL_X -2 - no need to move pointer at all. And so on. > I.e. should there be one also in dvb_usb_read_remote_control? Probably, I have not looked. -- Dmitry