From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Mike Rapoport <mike.rapoport@gmail.com>
Cc: Grazvydas Ignotas <notasas@gmail.com>,
linux-input@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v2] Input: ads7846: add regulator support
Date: Sat, 13 Feb 2010 19:52:10 +0000 [thread overview]
Message-ID: <20100213195210.GA405@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <f870da181002131140q45c91251mdd19f51bf5c9c9d7@mail.gmail.com>
On Sat, Feb 13, 2010 at 09:40:26PM +0200, Mike Rapoport wrote:
> On Sat, Feb 13, 2010 at 6:31 PM, Grazvydas Ignotas <notasas@gmail.com> wrote:
> > + ts->reg = regulator_get(&spi->dev, "vcc");
> "vcc" is way too generic name. What about "vcc-ts" or "vcc-touch"?
This should be OK as-is - the general style for regulators is to use
whatever the name the datasheet gives to the supply. The string used
is namespaced using the supplied struct device and isn't connected to
the strings used to name the regulator providing the supply so there
should be no cause for name collisions.
Only supplies for things like CPUs which don't currently have struct
devices associated with them have issues with name collisions.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-02-13 19:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-13 16:31 [PATCH v2] Input: ads7846: add regulator support Grazvydas Ignotas
2010-02-13 18:49 ` Mark Brown
2010-02-25 10:01 ` Dmitry Torokhov
2010-02-13 19:40 ` Mike Rapoport
2010-02-13 19:52 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100213195210.GA405@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mike.rapoport@gmail.com \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).