From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH v2] Input: ads7846: add regulator support Date: Sat, 13 Feb 2010 19:52:10 +0000 Message-ID: <20100213195210.GA405@opensource.wolfsonmicro.com> References: <1266078714-18155-1-git-send-email-notasas@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org To: Mike Rapoport Cc: Grazvydas Ignotas , linux-input@vger.kernel.org, Dmitry Torokhov , linux-omap@vger.kernel.org List-Id: linux-input@vger.kernel.org On Sat, Feb 13, 2010 at 09:40:26PM +0200, Mike Rapoport wrote: > On Sat, Feb 13, 2010 at 6:31 PM, Grazvydas Ignotas wrote: > > + =A0 =A0 =A0 ts->reg =3D regulator_get(&spi->dev, "vcc"); > "vcc" is way too generic name. What about "vcc-ts" or "vcc-touch"? This should be OK as-is - the general style for regulators is to use whatever the name the datasheet gives to the supply. The string used is namespaced using the supplied struct device and isn't connected to the strings used to name the regulator providing the supply so there should be no cause for name collisions. Only supplies for things like CPUs which don't currently have struct devices associated with them have issues with name collisions. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html