From: Vasily Khoruzhick <anarsoul@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: arhuaco@freaks-unidos.net, ben-linux@fluff.org,
linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH 2/4] s3c24xx_ts: report touch only when stylus is down
Date: Mon, 22 Feb 2010 11:03:00 +0200 [thread overview]
Message-ID: <201002221103.13677.anarsoul@gmail.com> (raw)
In-Reply-To: <20100222071403.GD2095@core.coreip.homeip.net>
[-- Attachment #1.1: Type: Text/Plain, Size: 573 bytes --]
В сообщении от 22 февраля 2010 09:14:03 автор Dmitry Torokhov написал:
> + /* Reset WAIT4INT state */
> + writel(0, ts.io + S3C2410_ADCTSC);
That's wrong, should be writel(S3C2410_ADCTSC_PULL_UP_DISABLE | AUTOPST, ts.io
+ S3C2410_ADCTSC), anyway it doesn't work even with this fix
> - if (pen_is_down)
> + if (pen_is_down) {
> + /* Reset WAIT4INT state */
> + writel(0, ts.io + S3C2410_ADCTSC);
Same note.
Regards
Vasily
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2010-02-22 9:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 16:32 [PATCH 0/4] s3c24xx_ts driver fixes Vasily Khoruzhick
2010-02-18 16:32 ` [PATCH 1/4] Add resources description for s3c24xx ts driver Vasily Khoruzhick
2010-02-18 16:32 ` [PATCH 2/4] s3c24xx_ts: report touch only when stylus is down Vasily Khoruzhick
2010-02-19 9:17 ` Dmitry Torokhov
2010-02-19 10:02 ` Vasily Khoruzhick
2010-02-21 7:35 ` Dmitry Torokhov
2010-02-21 9:05 ` Vasily Khoruzhick
2010-02-21 9:41 ` Dmitry Torokhov
2010-02-21 10:10 ` Vasily Khoruzhick
2010-02-21 10:28 ` Dmitry Torokhov
2010-02-21 10:33 ` Vasily Khoruzhick
2010-02-18 16:32 ` [PATCH 3/4] s3c24xx_adc: disable/enable IRQ on suspend/resume Vasily Khoruzhick
2010-02-18 16:32 ` [PATCH 4/4] s3c24xx_ts: re-enable IRQ on resume Vasily Khoruzhick
2010-02-19 9:05 ` Dmitry Torokhov
[not found] ` <201002212344.39633.anarsoul@gmail.com>
[not found] ` <20100221225125.GA18604@core.coreip.homeip.net>
[not found] ` <201002220058.52583.anarsoul@gmail.com>
2010-02-22 7:14 ` [PATCH 2/4] s3c24xx_ts: report touch only when stylus is down Dmitry Torokhov
2010-02-22 8:58 ` Vasily Khoruzhick
2010-02-22 9:03 ` Vasily Khoruzhick [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002221103.13677.anarsoul@gmail.com \
--to=anarsoul@gmail.com \
--cc=arhuaco@freaks-unidos.net \
--cc=ben-linux@fluff.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).