linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vojtech Pavlik <vojtech@suse.cz>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>, linux-input@vger.kernel.org
Subject: Re: Key for tablet rotation?
Date: Tue, 23 Feb 2010 11:29:50 +0100	[thread overview]
Message-ID: <20100223102950.GA7245@suse.cz> (raw)
In-Reply-To: <20100223092025.GF11685@suse.cz>

On Tue, Feb 23, 2010 at 10:20:25AM +0100, Vojtech Pavlik wrote:
> On Tue, Feb 16, 2010 at 02:56:02PM -0800, Dmitry Torokhov wrote:
> > Now if I only did not forget to CC Vojtech first time around...
> > 
> > On Tue, Feb 16, 2010 at 02:54:49PM -0800, Dmitry Torokhov wrote:
> > > On Tue, Feb 16, 2010 at 09:17:14PM +0000, Matthew Garrett wrote:
> > > > Many tablet PCs have a button to indicate that the screen should be 
> > > > rotated from landscape to portrait mode. There's currently no 
> > > > standardisation here - a couple of drivers seem to be using 
> > > > KEY_DIRECTION, and others are just being mapped to arbitrary F keys. So:
> > > > 
> > > > 1) What is KEY_DIRECTION supposed to be for?
> > > 
> > > Hmm, that is the good question. It looks like it's been introduced with
> > > the first patch for input events that Vojtech brought in 2.3 kernels and
> > > I do not see any users for it in mainline.
> > > 
> > > Vojtech, do you remember by any chance what you intended it to be used
> > > for?
> > > 
> > > > 2) If it's not suitable, do we still have space for a KEY_ROTATE?
> > > > 
> > > 
> > > We still have a few slots available but I'd lean towards KEY_DIRECTION
> > > (with better name maybe).
> 
> This is way too long ago, sorry. I suppose it was a key on one of the
> early extended AT keyboards, not really related to tablet computing.

Indeed, it was the case - it got in together with KEY_CYCLEWINDOWS,
KEY_MSDOS, KEY_WWW, and the (in)famous KEY_COFFEE.

> Now, if it's not used anywhere, it makes good sense to reuse it.

-- 
Vojtech Pavlik
Director SuSE Labs

      reply	other threads:[~2010-02-23 10:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-16 21:17 Key for tablet rotation? Matthew Garrett
2010-02-16 22:54 ` Dmitry Torokhov
2010-02-16 22:56   ` Dmitry Torokhov
2010-02-23  9:20     ` Vojtech Pavlik
2010-02-23 10:29       ` Vojtech Pavlik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100223102950.GA7245@suse.cz \
    --to=vojtech@suse.cz \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).