From: Pete Zaitcev <zaitcev@redhat.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-input@vger.kernel.org, zaitcev@redhat.com
Subject: Re: Zeroing the report before setting fields
Date: Tue, 9 Mar 2010 16:26:48 -0700 [thread overview]
Message-ID: <20100309162648.289871c4@redhat.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1003091340250.17799@pobox.suse.cz>
On Tue, 9 Mar 2010 13:41:24 +0100 (CET)
Jiri Kosina <jkosina@suse.cz> wrote:
> > > the end of the byte. But in case of, say, my keyboard, NumLock is mask
> > > 0x01 and CapsLock is 0x02. Invoking hid_output_field for NumLock
> > > definitely zeroes across CapsLock. The only reason this works is that
> > > the fields are sorted by the offset.
> > I think Jiri is the most qualified to answer questions like that about
> > HID (CCed) buit I think what you are proposing is reasonable and would
> > make the code safer indeed.
>
> Yes, the patch looks fine to me, thanks for CCing me.
>
> Pete, could you please send it to me along with your Signed-off-by line,
> so that I could queue it up?
Will do, thanks. I was hoping for a comment re. memset.
It is not needed for reports that consist of full bytes,
so it's a little wasteful. I aimed at simplicity, but I don't
know, what do you think?
-- Pete
next prev parent reply other threads:[~2010-03-09 23:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 21:33 Zeroing the report before setting fields Pete Zaitcev
2010-03-05 8:29 ` Dmitry Torokhov
2010-03-09 12:41 ` Jiri Kosina
2010-03-09 23:26 ` Pete Zaitcev [this message]
2010-03-13 22:25 ` Jiri Kosina
2010-03-22 5:09 ` Pete Zaitcev
2010-03-22 16:30 ` Jiri Kosina
2010-03-22 22:22 ` Pete Zaitcev
2010-04-12 16:08 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100309162648.289871c4@redhat.com \
--to=zaitcev@redhat.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).