Re: [PATCH v2] hid-magicmouse: Fix oops after device removal.

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Tue, Mar 09, 2010 at 06:47:35AM -0500, Michael Poole wrote:
> From 7466c15f196621c44b01e3e1f8abd61099e48989 Mon Sep 17 00:00:00 2001
> From: Michael Poole <mdpoole@troilus.org>
> Date: Tue, 9 Mar 2010 06:46:09 -0500
> Subject: [PATCH v2] hid-magicmouse: Fix oops after device removal.
> 
> Ask the HID core not to register an input device for the mouse.
> Fix an oops after removing the device, due to leaving the new
> input device registered.
> 
> Signed-off-by: Michael Poole <mdpoole@troilus.org>

Yep, looks good, thank you for making the change.

> ---
>  drivers/hid/hid-magicmouse.c |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hid/hid-magicmouse.c b/drivers/hid/hid-magicmouse.c
> index 4a3a94f..c174b64 100644
> --- a/drivers/hid/hid-magicmouse.c
> +++ b/drivers/hid/hid-magicmouse.c
> @@ -353,7 +353,7 @@ static int magicmouse_probe(struct hid_device *hdev,
>  		goto err_free;
>  	}
>  
> -	ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT);
> +	ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT & ~HID_CONNECT_HIDINPUT);
>  	if (ret) {
>  		dev_err(&hdev->dev, "magicmouse hw start failed\n");
>  		goto err_free;
> @@ -409,8 +409,11 @@ err_free:
>  
>  static void magicmouse_remove(struct hid_device *hdev)
>  {
> +	struct magicmouse_sc *msc = hid_get_drvdata(hdev);
> +
>  	hid_hw_stop(hdev);
> -	kfree(hid_get_drvdata(hdev));
> +	input_unregister_device(msc->input);
> +	kfree(msc);
>  }
>  
>  static const struct hid_device_id magic_mice[] = {
> -- 
> 1.7.0.2
> 

-- 
Dmitry