[git pull] Input updates for 2.6.34-rc0

[git pull] Input updates for 2.6.34-rc0

[Dmitry Torokhov]

Hi Linus,

Please pull from:

	git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus
or
	master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus

to receive first round of updates for the input subsystem.

Changelog:
---------

Alberto Panizzo (1):
      Input: add imx-keypad driver to support the IMX Keypad Port

Andrew Clayton (1):
      Input: rotary-encoder - set gpio direction for each requested gpio

Bastian Blank (1):
      Input: wacom - get features from driver info

Benjamin Valentin (1):
      Input: xpad - add rumble support for original xbox controller

David Härdeman (1):
      Input: winbond-cir - fix suspend/resume

Dmitry Torokhov (26):
      Input: serio - use device core to create 'id' attribute group
      Input: serio - let device core tell us if device was registered
      Input: serio - use list_first_entry() helper
      Input: serio - use pr_xxx() and dev_xxx() helpers
      Input: gameport - let device core tell us if device was registered
      Input: gameport - make use of list_first_entry() helper
      Input: gameport - switch to using pr_xxx() and dev_xxx()
      Input: automatically reset KEY_RESERVED bit for all input devices
      Input: cleanse capabilities bits before registering device
      Input: psmouse - remove unused 'autocal' parameter from hgpk protocol
      Input: atkbd - switch to dev_err() and friends
      Input: elo - switch to using dev_xxx() when printing messages
      Input: implement input filters
      Input: Mac button emulation - implement as an input filter
      Input: Mac button emulation  - allow compiling as a module
      Input: add match() method to input hanlders
      Input: uinput - mark as non-seekable
      Input: mark input interfaces as non-seekable
      Input: wacom - constify product features data
      Input: gamecon - fix some formatting issues
      Input: gamecon - simplify coordinate calculation for PSX
      Input: gamecon - simplify pad type handling
      Input: gamecon - constify some of the setup structures
      Input: gamecon - use pr_err() and friends
      Input: add KEY_WPS_BUTTON definition
      Input: atkbd - release previously reserved keycodes 248 - 254

Eric Miao (2):
      Input: mark {corgi,spitz,tosa}kbd drivers deprecated
      Input: schedule corgi_ssp and corgi_ts to be removed

Grazvydas Ignotas (1):
      Input: ads7846 - add regulator support

H Hartley Sweeten (1):
      Input: ep93xx_keypad - cleanup and use matrix_keypad helpers

Jason Childs (1):
      Input: wacom - use per-device instance of wacom_features

Magnus Damm (5):
      Input: sh_keysc - add mode 4 and mode 5 support
      Input: sh_keysc - factor out hw access functions
      Input: sh_keysc - switch to using bitmaps
      Input: sh_keysc - update the driver with mode 6
      Input: sh_keysc - enable building on SH-Mobile ARM

Mark Brown (1):
      Input: wm97xx - provide coordinate logs for accelerated I/O

Michael Hennerich (1):
      Input: ADP5588 - add support for ADP5587 devices

Mika Westerberg (1):
      Input: gpio-keys - add support for disabling gpios through sysfs

Márton Németh (6):
      Input: make i2c device ids constant
      Input: xilinx_ps2 - make Open Firmware device ids constant
      Input: make PCI device ids constant
      Input: ns558 - make pnp device ids constant
      Input: xen-kbdfront - make xenbus device ids constant
      Input: make USB device ids constant

Nicolas Léveillé (1):
      Input: xpad - allow using triggers as buttons rather than axes

Ondrej Zary (4):
      Input: usbtouchscreen - convert from usb_device to usb_interface
      Input: usbtouchscreen - find input endpoint automatically
      Input: usbtouchscreen - add NEXIO (or iNexio) support
      Input: usbtouchscreen - fix leaks and check return value of usb_submit_urb()

Ping Cheng (1):
      Input: wacom - add device type to device name string

Scott Moreau (1):
      Input: gamecon - add rumble support for N64 pads

Tai-hwa Liang (1):
      Input: update Sentelic protocol documentation

Thadeu Lima de Souza Cascardo (1):
      Input: uinput - remove BKL from uinput_open function

Tobias Klauser (1):
      Input: xilinx_ps2 - use resource_size

Vasily Khoruzhick (2):
      Input: s3c24xx_ts - re-enable IRQ on resume
      Input: s3c24xx_ts - report touch only when stylus is down


Diffstat:
--------

 Documentation/feature-removal-schedule.txt        |   23 +
 Documentation/input/sentelic.txt                  |  124 ++++-
 arch/arm/mach-ep93xx/include/mach/ep93xx_keypad.h |   14 +-
 drivers/char/keyboard.c                           |   29 +-
 drivers/input/evdev.c                             |    2 +
 drivers/input/gameport/emu10k1-gp.c               |    2 +-
 drivers/input/gameport/fm801-gp.c                 |    2 +-
 drivers/input/gameport/gameport.c                 |   98 ++--
 drivers/input/gameport/ns558.c                    |    2 +-
 drivers/input/input.c                             |   90 +++-
 drivers/input/joydev.c                            |   34 +-
 drivers/input/joystick/Kconfig                    |    1 +
 drivers/input/joystick/gamecon.c                  |  664 ++++++++++++++-------
 drivers/input/joystick/xpad.c                     |  253 +++++---
 drivers/input/keyboard/Kconfig                    |   33 +-
 drivers/input/keyboard/Makefile                   |    1 +
 drivers/input/keyboard/adp5588-keys.c             |    6 +-
 drivers/input/keyboard/atkbd.c                    |  309 +++++-----
 drivers/input/keyboard/ep93xx_keypad.c            |   40 +-
 drivers/input/keyboard/gpio_keys.c                |  318 ++++++++++-
 drivers/input/keyboard/imx_keypad.c               |  594 ++++++++++++++++++
 drivers/input/keyboard/qt2160.c                   |    2 +-
 drivers/input/keyboard/sh_keysc.c                 |  145 +++--
 drivers/input/misc/apanel.c                       |    2 +-
 drivers/input/misc/rotary_encoder.c               |   14 +
 drivers/input/misc/uinput.c                       |    4 +-
 drivers/input/misc/winbond-cir.c                  |  213 ++++----
 drivers/input/mouse/hgpk.c                        |    4 -
 drivers/input/serio/pcips2.c                      |    2 +-
 drivers/input/serio/serio.c                       |  131 ++---
 drivers/input/serio/xilinx_ps2.c                  |    6 +-
 drivers/input/tablet/gtco.c                       |    2 +-
 drivers/input/tablet/wacom.h                      |    5 +-
 drivers/input/tablet/wacom_sys.c                  |   70 ++-
 drivers/input/tablet/wacom_wac.c                  |  408 +++++++------
 drivers/input/tablet/wacom_wac.h                  |   17 +-
 drivers/input/touchscreen/Kconfig                 |    6 +-
 drivers/input/touchscreen/ads7846.c               |   28 +-
 drivers/input/touchscreen/elo.c                   |  225 ++++----
 drivers/input/touchscreen/mainstone-wm97xx.c      |    3 +
 drivers/input/touchscreen/s3c2410_ts.c            |   31 +-
 drivers/input/touchscreen/tsc2007.c               |    2 +-
 drivers/input/touchscreen/usbtouchscreen.c        |  317 +++++++++-
 drivers/input/touchscreen/zylonite-wm97xx.c       |    3 +
 drivers/input/xen-kbdfront.c                      |    2 +-
 drivers/macintosh/Kconfig                         |    7 +-
 drivers/macintosh/mac_hid.c                       |  266 ++++++---
 include/linux/gameport.h                          |    1 -
 include/linux/gpio_keys.h                         |    1 +
 include/linux/input.h                             |   17 +-
 include/linux/input/sh_keysc.h                    |    7 +-
 include/linux/kbd_kern.h                          |    3 -
 include/linux/serio.h                             |    1 -
 53 files changed, 3250 insertions(+), 1334 deletions(-)
 create mode 100644 drivers/input/keyboard/imx_keypad.c

-- 
Dmitry

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [git pull] Input updates for 2.6.34-rc0

[Mike Frysinger]

On Mon, Mar 1, 2010 at 03:03, Dmitry Torokhov wrote:
> Hi Linus,
>
> Please pull from:
>
>        git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus
> or
>        master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus
>
> to receive first round of updates for the input subsystem.

i'm trying to figure out what the problem is with the ADXL34x and
AD714x drivers you seem to have accepted (at least, you didnt say
there was anything left for us to do).  i would have expected them to
be in 2.6.33/2.6.34 already, but it seems they arent moving now.  so
what's up ?
-mike

Re: [git pull] Input updates for 2.6.34-rc0

[Cory Maccarrone]

On Tue, Mar 9, 2010 at 6:44 AM, Mike Frysinger <vapier.adi@gmail.com> wrote:
> On Mon, Mar 1, 2010 at 03:03, Dmitry Torokhov wrote:
>> Hi Linus,
>>
>> Please pull from:
>>
>>        git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus
>> or
>>        master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus
>>
>> to receive first round of updates for the input subsystem.
>
> i'm trying to figure out what the problem is with the ADXL34x and
> AD714x drivers you seem to have accepted (at least, you didnt say
> there was anything left for us to do).  i would have expected them to
> be in 2.6.33/2.6.34 already, but it seems they arent moving now.  so
> what's up ?
> -mike
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

I'm in the same boat with my TSC2046 driver.  Any idea why this hasn't
moved?  I have received no comments, nor has the driver been included
/ accepted.  Do I need to make revisions, or can it be included?

- Cory
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [git pull] Input updates for 2.6.34-rc0

[Dmitry Torokhov]

On Tue, Mar 09, 2010 at 09:44:08AM -0500, Mike Frysinger wrote:
> On Mon, Mar 1, 2010 at 03:03, Dmitry Torokhov wrote:
> > Hi Linus,
> >
> > Please pull from:
> >
> >        git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus
> > or
> >        master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus
> >
> > to receive first round of updates for the input subsystem.
> 
> i'm trying to figure out what the problem is with the ADXL34x and
> AD714x drivers you seem to have accepted (at least, you didnt say
> there was anything left for us to do).  i would have expected them to
> be in 2.6.33/2.6.34 already, but it seems they arent moving now.  so
> what's up ?

I am still spooked by the fact that this is an accelerometer and does
not have to be an input device but maybe used for different purposes as
well.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [git pull] Input updates for 2.6.34-rc0

[Dmitry Torokhov]

On Tue, Mar 09, 2010 at 08:15:06AM -0800, Cory Maccarrone wrote:
> On Tue, Mar 9, 2010 at 6:44 AM, Mike Frysinger <vapier.adi@gmail.com> wrote:
> > On Mon, Mar 1, 2010 at 03:03, Dmitry Torokhov wrote:
> >> Hi Linus,
> >>
> >> Please pull from:
> >>
> >>        git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus
> >> or
> >>        master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus
> >>
> >> to receive first round of updates for the input subsystem.
> >
> > i'm trying to figure out what the problem is with the ADXL34x and
> > AD714x drivers you seem to have accepted (at least, you didnt say
> > there was anything left for us to do).  i would have expected them to
> > be in 2.6.33/2.6.34 already, but it seems they arent moving now.  so
> > what's up ?
> > -mike
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-input" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
> 
> I'm in the same boat with my TSC2046 driver.  Any idea why this hasn't
> moved?  I have received no comments, nor has the driver been included
> / accepted.  Do I need to make revisions, or can it be included?
> 

I am yet to review the driver (usual time constraints, unfortunately).
Very sorry about it.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [git pull] Input updates for 2.6.34-rc0

[Mike Frysinger]

On Tue, Mar 9, 2010 at 12:51, Dmitry Torokhov wrote:
> On Tue, Mar 09, 2010 at 09:44:08AM -0500, Mike Frysinger wrote:
>> On Mon, Mar 1, 2010 at 03:03, Dmitry Torokhov wrote:
>> > Hi Linus,
>> >
>> > Please pull from:
>> >
>> >        git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus
>> > or
>> >        master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus
>> >
>> > to receive first round of updates for the input subsystem.
>>
>> i'm trying to figure out what the problem is with the ADXL34x and
>> AD714x drivers you seem to have accepted (at least, you didnt say
>> there was anything left for us to do).  i would have expected them to
>> be in 2.6.33/2.6.34 already, but it seems they arent moving now.  so
>> what's up ?
>
> I am still spooked by the fact that this is an accelerometer and does
> not have to be an input device but maybe used for different purposes as
> well.

the AD714x is not an accelerometer, it's a capacitance touch sensor

i understand the ADXL34x is a bit wonky, but what else would you
propose ?  or just leave the driver in limbo forever until people
forget about it ?
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [git pull] Input updates for 2.6.34-rc0

[Dmitry Torokhov]

On Tue, Mar 09, 2010 at 12:58:24PM -0500, Mike Frysinger wrote:
> On Tue, Mar 9, 2010 at 12:51, Dmitry Torokhov wrote:
> > On Tue, Mar 09, 2010 at 09:44:08AM -0500, Mike Frysinger wrote:
> >> On Mon, Mar 1, 2010 at 03:03, Dmitry Torokhov wrote:
> >> > Hi Linus,
> >> >
> >> > Please pull from:
> >> >
> >> >        git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus
> >> > or
> >> >        master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus
> >> >
> >> > to receive first round of updates for the input subsystem.
> >>
> >> i'm trying to figure out what the problem is with the ADXL34x and
> >> AD714x drivers you seem to have accepted (at least, you didnt say
> >> there was anything left for us to do).  i would have expected them to
> >> be in 2.6.33/2.6.34 already, but it seems they arent moving now.  so
> >> what's up ?
> >
> > I am still spooked by the fact that this is an accelerometer and does
> > not have to be an input device but maybe used for different purposes as
> > well.
> 
> the AD714x is not an accelerometer, it's a capacitance touch sensor
>

OK, will dig it up.
 
> i understand the ADXL34x is a bit wonky, but what else would you
> propose ?  or just leave the driver in limbo forever until people
> forget about it ?

No, just till we have proper framework for it to be merged into.

-- 
Dmitry

Re: [git pull] Input updates for 2.6.34-rc0

[Mike Frysinger]

On Tue, Mar 9, 2010 at 13:10, Dmitry Torokhov wrote:
> On Tue, Mar 09, 2010 at 12:58:24PM -0500, Mike Frysinger wrote:
>> On Tue, Mar 9, 2010 at 12:51, Dmitry Torokhov wrote:
>> > On Tue, Mar 09, 2010 at 09:44:08AM -0500, Mike Frysinger wrote:
>> >> On Mon, Mar 1, 2010 at 03:03, Dmitry Torokhov wrote:
>> >> > Hi Linus,
>> >> >
>> >> > Please pull from:
>> >> >
>> >> >        git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus
>> >> > or
>> >> >        master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus
>> >> >
>> >> > to receive first round of updates for the input subsystem.
>> >>
>> >> i'm trying to figure out what the problem is with the ADXL34x and
>> >> AD714x drivers you seem to have accepted (at least, you didnt say
>> >> there was anything left for us to do).  i would have expected them to
>> >> be in 2.6.33/2.6.34 already, but it seems they arent moving now.  so
>> >> what's up ?
>> >
>> > I am still spooked by the fact that this is an accelerometer and does
>> > not have to be an input device but maybe used for different purposes as
>> > well.
>>
>> the AD714x is not an accelerometer, it's a capacitance touch sensor
>>
>
> OK, will dig it up.

thanks

>> i understand the ADXL34x is a bit wonky, but what else would you
>> propose ?  or just leave the driver in limbo forever until people
>> forget about it ?
>
> No, just till we have proper framework for it to be merged into.

that sounds fine, but is there actually something in progress for that
?  waiting for a framework no one is working on is the same in
practice ...
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [git pull] Input updates for 2.6.34-rc0

[Jonathan Cameron]

On 03/09/10 17:58, Mike Frysinger wrote:
> On Tue, Mar 9, 2010 at 12:51, Dmitry Torokhov wrote:
>> On Tue, Mar 09, 2010 at 09:44:08AM -0500, Mike Frysinger wrote:
>>> On Mon, Mar 1, 2010 at 03:03, Dmitry Torokhov wrote:
>>>> Hi Linus,
>>>>
>>>> Please pull from:
>>>>
>>>>        git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus
>>>> or
>>>>        master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus
>>>>
>>>> to receive first round of updates for the input subsystem.
>>>
>>> i'm trying to figure out what the problem is with the ADXL34x and
>>> AD714x drivers you seem to have accepted (at least, you didnt say
>>> there was anything left for us to do).  i would have expected them to
>>> be in 2.6.33/2.6.34 already, but it seems they arent moving now.  so
>>> what's up ?
>>
>> I am still spooked by the fact that this is an accelerometer and does
>> not have to be an input device but maybe used for different purposes as
>> well.
> 
> the AD714x is not an accelerometer, it's a capacitance touch sensor
> 
> i understand the ADXL34x is a bit wonky, but what else would you
> propose ?  or just leave the driver in limbo forever until people
> forget about it ?
Hi Mike,

Perhaps whilst this remains in debate it might merge under misc, or
even staging temporarily.  That would avoid setting a precedent for
putting them in input.  I personally agree with Dmitry's wish to
avoid feature drift in input, but then we don't have anything else ready
for the big time.  Under staging the entire TODO list would be along
lines of awaiting a suitable framework...  This is effectively what
is going to happen to the various Ambient Light sensor drivers for
pretty much the same reason (see responses to our recent pull request).

We certainly want to be careful not to loose good drivers like this
and also to make them available to those who wish to use them.

Jonathan

Re: [git pull] Input updates for 2.6.34-rc0

[Dmitry Torokhov]

On Tue, Mar 09, 2010 at 01:13:34PM -0500, Mike Frysinger wrote:
> On Tue, Mar 9, 2010 at 13:10, Dmitry Torokhov wrote:
> > On Tue, Mar 09, 2010 at 12:58:24PM -0500, Mike Frysinger wrote:
> >> On Tue, Mar 9, 2010 at 12:51, Dmitry Torokhov wrote:
> >> > On Tue, Mar 09, 2010 at 09:44:08AM -0500, Mike Frysinger wrote:
> >> >> On Mon, Mar 1, 2010 at 03:03, Dmitry Torokhov wrote:
> >> >> > Hi Linus,
> >> >> >
> >> >> > Please pull from:
> >> >> >
> >> >> >        git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus
> >> >> > or
> >> >> >        master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus
> >> >> >
> >> >> > to receive first round of updates for the input subsystem.
> >> >>
> >> >> i'm trying to figure out what the problem is with the ADXL34x and
> >> >> AD714x drivers you seem to have accepted (at least, you didnt say
> >> >> there was anything left for us to do).  i would have expected them to
> >> >> be in 2.6.33/2.6.34 already, but it seems they arent moving now.  so
> >> >> what's up ?
> >> >
> >> > I am still spooked by the fact that this is an accelerometer and does
> >> > not have to be an input device but maybe used for different purposes as
> >> > well.
> >>
> >> the AD714x is not an accelerometer, it's a capacitance touch sensor
> >>
> >
> > OK, will dig it up.
> 
> thanks
> 
> >> i understand the ADXL34x is a bit wonky, but what else would you
> >> propose ?  or just leave the driver in limbo forever until people
> >> forget about it ?
> >
> > No, just till we have proper framework for it to be merged into.
> 
> that sounds fine, but is there actually something in progress for that
> ?  waiting for a framework no one is working on is the same in
> practice ...

I have high hopes that IIO will fill the needs of these kinds of devices.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [git pull] Input updates for 2.6.34-rc0

[Mike Frysinger]

On Tue, Mar 9, 2010 at 13:18, Jonathan Cameron wrote:
> On 03/09/10 17:58, Mike Frysinger wrote:
>> On Tue, Mar 9, 2010 at 12:51, Dmitry Torokhov wrote:
>>> On Tue, Mar 09, 2010 at 09:44:08AM -0500, Mike Frysinger wrote:
>>>> On Mon, Mar 1, 2010 at 03:03, Dmitry Torokhov wrote:
>>>>> Hi Linus,
>>>>>
>>>>> Please pull from:
>>>>>
>>>>>        git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus
>>>>> or
>>>>>        master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus
>>>>>
>>>>> to receive first round of updates for the input subsystem.
>>>>
>>>> i'm trying to figure out what the problem is with the ADXL34x and
>>>> AD714x drivers you seem to have accepted (at least, you didnt say
>>>> there was anything left for us to do).  i would have expected them to
>>>> be in 2.6.33/2.6.34 already, but it seems they arent moving now.  so
>>>> what's up ?
>>>
>>> I am still spooked by the fact that this is an accelerometer and does
>>> not have to be an input device but maybe used for different purposes as
>>> well.
>>
>> the AD714x is not an accelerometer, it's a capacitance touch sensor
>>
>> i understand the ADXL34x is a bit wonky, but what else would you
>> propose ?  or just leave the driver in limbo forever until people
>> forget about it ?
>
> Perhaps whilst this remains in debate it might merge under misc, or
> even staging temporarily.  That would avoid setting a precedent for
> putting them in input.  I personally agree with Dmitry's wish to
> avoid feature drift in input, but then we don't have anything else ready
> for the big time.  Under staging the entire TODO list would be along
> lines of awaiting a suitable framework...  This is effectively what
> is going to happen to the various Ambient Light sensor drivers for
> pretty much the same reason (see responses to our recent pull request).
>
> We certainly want to be careful not to loose good drivers like this
> and also to make them available to those who wish to use them.

i dont have any problems with where exactly the driver gets merged, or
if we have a goal we're working towards (in terms of a "better"
place).  but drivers sitting in perpetual limbo sucks.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [git pull] Input updates for 2.6.34-rc0

[Jonathan Cameron]

On 03/09/10 18:21, Mike Frysinger wrote:
> On Tue, Mar 9, 2010 at 13:18, Jonathan Cameron wrote:
>> On 03/09/10 17:58, Mike Frysinger wrote:
>>> On Tue, Mar 9, 2010 at 12:51, Dmitry Torokhov wrote:
>>>> On Tue, Mar 09, 2010 at 09:44:08AM -0500, Mike Frysinger wrote:
>>>>> On Mon, Mar 1, 2010 at 03:03, Dmitry Torokhov wrote:
>>>>>> Hi Linus,
>>>>>>
>>>>>> Please pull from:
>>>>>>
>>>>>>        git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus
>>>>>> or
>>>>>>        master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus
>>>>>>
>>>>>> to receive first round of updates for the input subsystem.
>>>>>
>>>>> i'm trying to figure out what the problem is with the ADXL34x and
>>>>> AD714x drivers you seem to have accepted (at least, you didnt say
>>>>> there was anything left for us to do).  i would have expected them to
>>>>> be in 2.6.33/2.6.34 already, but it seems they arent moving now.  so
>>>>> what's up ?
>>>>
>>>> I am still spooked by the fact that this is an accelerometer and does
>>>> not have to be an input device but maybe used for different purposes as
>>>> well.
>>>
>>> the AD714x is not an accelerometer, it's a capacitance touch sensor
>>>
>>> i understand the ADXL34x is a bit wonky, but what else would you
>>> propose ?  or just leave the driver in limbo forever until people
>>> forget about it ?
>>
>> Perhaps whilst this remains in debate it might merge under misc, or
>> even staging temporarily.  That would avoid setting a precedent for
>> putting them in input.  I personally agree with Dmitry's wish to
>> avoid feature drift in input, but then we don't have anything else ready
>> for the big time.  Under staging the entire TODO list would be along
>> lines of awaiting a suitable framework...  This is effectively what
>> is going to happen to the various Ambient Light sensor drivers for
>> pretty much the same reason (see responses to our recent pull request).
>>
>> We certainly want to be careful not to loose good drivers like this
>> and also to make them available to those who wish to use them.
> 
> i dont have any problems with where exactly the driver gets merged, or
> if we have a goal we're working towards (in terms of a "better"
> place).  but drivers sitting in perpetual limbo sucks.
> -mike
> 
In that case, I suggest asking Greg KH to pull it into staging for now
with suitable explanation (and perhaps an ack for putting it there from
Dmitry?)

Jonathan

Re: [git pull] Input updates for 2.6.34-rc0

[Robin Getz]

On Tue 9 Mar 2010 13:20, Dmitry Torokhov pondered:
> On Tue, Mar 09, 2010 at 01:13:34PM -0500, Mike Frysinger wrote:
> > On Tue, Mar 9, 2010 at 13:10, Dmitry Torokhov wrote:
> > > On Tue, Mar 09, 2010 at 12:58:24PM -0500, Mike Frysinger wrote:
> > >> On Tue, Mar 9, 2010 at 12:51, Dmitry Torokhov wrote:
> > >> > On Tue, Mar 09, 2010 at 09:44:08AM -0500, Mike Frysinger wrote:
[snip]
> > >> i understand the ADXL34x is a bit wonky, but what else would you
> > >> propose ?  or just leave the driver in limbo forever until people
> > >> forget about it ?
> > >
> > > No, just till we have proper framework for it to be merged into.
> > 
> > that sounds fine, but is there actually something in progress for that
> > ?  waiting for a framework no one is working on is the same in
> > practice ...
> 
> I have high hopes that IIO will fill the needs of these kinds of devices.

The fact of things is that many people are using this as pointing device.

I'm not convinced that IIO is the best place for these types of things...

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [git pull] Input updates for 2.6.34-rc0

[Hennerich, Michael]

Robin Getz wrote on 2010-03-09:
> On Tue 9 Mar 2010 13:20, Dmitry Torokhov pondered:
>> On Tue, Mar 09, 2010 at 01:13:34PM -0500, Mike Frysinger wrote:
>>> On Tue, Mar 9, 2010 at 13:10, Dmitry Torokhov wrote:
>>>> On Tue, Mar 09, 2010 at 12:58:24PM -0500, Mike Frysinger wrote:
>>>>> On Tue, Mar 9, 2010 at 12:51, Dmitry Torokhov wrote:
>>>>>> On Tue, Mar 09, 2010 at 09:44:08AM -0500, Mike Frysinger
> wrote:
> [snip]
>>>>> i understand the ADXL34x is a bit wonky, but what else would you
>>>>> propose ?  or just leave the driver in limbo forever until people
>>>>> forget about it ?
>>>>
>>>> No, just till we have proper framework for it to be merged into.
>>>
>>> that sounds fine, but is there actually something in progress for
>>> that ?  waiting for a framework no one is working on is the same
>>> in practice ...
>>
>> I have high hopes that IIO will fill the needs of these kinds of
> devices.
>
> The fact of things is that many people are using this as pointing device.
>
> I'm not convinced that IIO is the best place for these types of
> things...

Very true - this driver was originally targeted and designed as a typical human interface input device.

Greetings,
Michael

Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft Muenchen, Registergericht Muenchen HRB 4036 Geschaeftsfuehrer Thomas Wessel, William A. Martin, Margaret Seif

Re: [git pull] Input updates for 2.6.34-rc0

[Robin Getz]

On Wed 10 Mar 2010 03:30, Hennerich, Michael pondered:
> Robin Getz wrote on 2010-03-09:
> > On Tue 9 Mar 2010 13:20, Dmitry Torokhov pondered:
> >> On Tue, Mar 09, 2010 at 01:13:34PM -0500, Mike Frysinger wrote:
> >>> On Tue, Mar 9, 2010 at 13:10, Dmitry Torokhov wrote:
> >>>> On Tue, Mar 09, 2010 at 12:58:24PM -0500, Mike Frysinger wrote:
> >>>>> On Tue, Mar 9, 2010 at 12:51, Dmitry Torokhov wrote:
> >>>>>> On Tue, Mar 09, 2010 at 09:44:08AM -0500, Mike Frysinger
> > wrote:
> > [snip]
> >>>>> i understand the ADXL34x is a bit wonky, but what else would you
> >>>>> propose ?  or just leave the driver in limbo forever until people
> >>>>> forget about it ?
> >>>>
> >>>> No, just till we have proper framework for it to be merged into.
> >>>
> >>> that sounds fine, but is there actually something in progress for
> >>> that ?  waiting for a framework no one is working on is the same
> >>> in practice ...
> >>
> >> I have high hopes that IIO will fill the needs of these kinds of
> > devices.
> >
> > The fact of things is that many people are using this as pointing device.
> >
> > I'm not convinced that IIO is the best place for these types of
> > things...
> 
> Very true - this driver was originally targeted and designed as a 
> typical human interface input device. 
> 

Dmitry:

Care to comment? I would prefer to come to some sort of conclusion. As Mike 
said - leaving the driver in limbo forever isn't really a solution for 
anyone....

Re: [git pull] Input updates for 2.6.34-rc0

[Dmitry Torokhov]

On Fri, Mar 12, 2010 at 03:55:37PM -0500, Robin Getz wrote:
> On Wed 10 Mar 2010 03:30, Hennerich, Michael pondered:
> > Robin Getz wrote on 2010-03-09:
> > > On Tue 9 Mar 2010 13:20, Dmitry Torokhov pondered:
> > >> On Tue, Mar 09, 2010 at 01:13:34PM -0500, Mike Frysinger wrote:
> > >>> On Tue, Mar 9, 2010 at 13:10, Dmitry Torokhov wrote:
> > >>>> On Tue, Mar 09, 2010 at 12:58:24PM -0500, Mike Frysinger wrote:
> > >>>>> On Tue, Mar 9, 2010 at 12:51, Dmitry Torokhov wrote:
> > >>>>>> On Tue, Mar 09, 2010 at 09:44:08AM -0500, Mike Frysinger
> > > wrote:
> > > [snip]
> > >>>>> i understand the ADXL34x is a bit wonky, but what else would you
> > >>>>> propose ?  or just leave the driver in limbo forever until people
> > >>>>> forget about it ?
> > >>>>
> > >>>> No, just till we have proper framework for it to be merged into.
> > >>>
> > >>> that sounds fine, but is there actually something in progress for
> > >>> that ?  waiting for a framework no one is working on is the same
> > >>> in practice ...
> > >>
> > >> I have high hopes that IIO will fill the needs of these kinds of
> > > devices.
> > >
> > > The fact of things is that many people are using this as pointing device.
> > >
> > > I'm not convinced that IIO is the best place for these types of
> > > things...
> > 
> > Very true - this driver was originally targeted and designed as a 
> > typical human interface input device. 
> > 
> 
> Dmitry:
> 
> Care to comment? I would prefer to come to some sort of conclusion. As Mike 
> said - leaving the driver in limbo forever isn't really a solution for 
> anyone....

OK, you swayed my opinion about 3-axis accelerometers, I will review the
patch again (although IIRC I was pretty satisfied with it) and apply.

-- 
Dmitry

Re: [git pull] Input updates for 2.6.34-rc0

[Dmitry Torokhov]

On Tue, Mar 09, 2010 at 01:13:34PM -0500, Mike Frysinger wrote:
> On Tue, Mar 9, 2010 at 13:10, Dmitry Torokhov wrote:
> > On Tue, Mar 09, 2010 at 12:58:24PM -0500, Mike Frysinger wrote:
> >> On Tue, Mar 9, 2010 at 12:51, Dmitry Torokhov wrote:
> >> > On Tue, Mar 09, 2010 at 09:44:08AM -0500, Mike Frysinger wrote:
> >> >> On Mon, Mar 1, 2010 at 03:03, Dmitry Torokhov wrote:
> >> >> > Hi Linus,
> >> >> >
> >> >> > Please pull from:
> >> >> >
> >> >> >        git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus
> >> >> > or
> >> >> >        master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus
> >> >> >
> >> >> > to receive first round of updates for the input subsystem.
> >> >>
> >> >> i'm trying to figure out what the problem is with the ADXL34x and
> >> >> AD714x drivers you seem to have accepted (at least, you didnt say
> >> >> there was anything left for us to do).  i would have expected them to
> >> >> be in 2.6.33/2.6.34 already, but it seems they arent moving now.  so
> >> >> what's up ?
> >> >
> >> > I am still spooked by the fact that this is an accelerometer and does
> >> > not have to be an input device but maybe used for different purposes as
> >> > well.
> >>
> >> the AD714x is not an accelerometer, it's a capacitance touch sensor
> >>
> >
> > OK, will dig it up.
> 
> thanks
> 

Mike, could you please take a look at mny 'next' branch and give the
version there a try - I made a couple of small changes before
applying...

Thanks!

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [git pull] Input updates for 2.6.34-rc0

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

On Mon, Mar 22, 2010 at 02:37, Dmitry Torokhov wrote:
> On Tue, Mar 09, 2010 at 01:13:34PM -0500, Mike Frysinger wrote:
>> On Tue, Mar 9, 2010 at 13:10, Dmitry Torokhov wrote:
>> > On Tue, Mar 09, 2010 at 12:58:24PM -0500, Mike Frysinger wrote:
>> >> the AD714x is not an accelerometer, it's a capacitance touch sensor
>> >
>> > OK, will dig it up.
>>
>> thanks
>
> Mike, could you please take a look at mny 'next' branch and give the
> version there a try - I made a couple of small changes before
> applying...

changes look ok to me, and it seems to build fine.  maybe Barry can
give it a quick test to make sure it still probes/works, but i dont
see anything to suggest it wouldnt ...

if you're doing cosmetic fixes, i'd suggest squashing the attached into it too.
-mike

[-- Attachment #2: ad714x-comments.patch --]
[-- Type: application/octet-stream, Size: 1267 bytes --]

diff --git a/drivers/input/misc/ad714x.c b/drivers/input/misc/ad714x.c
index ed6381a..f8c4e45 100644
--- a/drivers/input/misc/ad714x.c
+++ b/drivers/input/misc/ad714x.c
@@ -234,7 +234,6 @@ static int ad714x_cal_abs_pos(struct ad714x_chip *ad714x,
 	return (max_coord / (end_stage - start_stage)) * a_param / b_param;
 }
 
-
 /*
  * One button can connect to multi positive and negative of CDCs
  * Multi-buttons can connect to same positive/negative of one CDC
@@ -426,7 +425,8 @@ static void ad714x_slider_state_machine(struct ad714x_chip *ad714x, int idx)
 	}
 }
 
-/* When the scroll wheel is activated, we compute the absolute position based
+/*
+ * When the scroll wheel is activated, we compute the absolute position based
  * on the sensor values. To calculate the position, we first determine the
  * sensor that has the greatest response among the 8 sensors that constitutes
  * the scrollwheel. Then we determined the 2 sensors on either sides of the
@@ -1005,7 +1005,7 @@ static void ad714x_hw_init(struct ad714x_chip *ad714x)
 	unsigned short reg_base;
 	unsigned short data;
 
-	/* configuration CDC and interrupts*/
+	/* configuration CDC and interrupts */
 
 	for (i = 0; i < STAGE_NUM; i++) {
 		reg_base = AD714X_STAGECFG_REG + i * STAGE_CFGREG_NUM;