[PATCH] input: alps: Add support for the touchpad of the Toshiba Tecra A11-11L

[PATCH] input: alps: Add support for the touchpad of the Toshiba Tecra A11-11L

[Thomas Bächler]

Signed-off-by: Thomas Bächler <thomas@archlinux.org>
---
This patch was made by trial-and-error, I copied the byte0 and
mask0 value from another model, tried different flags settings
and it seems to work. I have no idea if there might be side-
effects due to incorrect settings. Please tell me if I can do
anything to verify or correct these values.

 drivers/input/mouse/alps.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
index f93c2c0..f6dad83 100644
--- a/drivers/input/mouse/alps.c
+++ b/drivers/input/mouse/alps.c
@@ -63,6 +63,8 @@ static const struct alps_model_info alps_model_data[] = {
 	{ { 0x62, 0x02, 0x14 }, 0xcf, 0xcf,
 		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },
 	{ { 0x73, 0x02, 0x50 }, 0xcf, 0xcf, ALPS_FOUR_BUTTONS },	  /* Dell Vostro 1400 */
+	{ { 0x52, 0x01, 0x14 }, 0xff, 0xff,
+		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },	  /* Toshiba Tecra A11-11L */
 };
 
 /*
-- 
1.7.0.1

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] input: alps: Add support for the touchpad of the Toshiba Tecra A11-11L

[Dmitry Torokhov]

Hi Thomas,

On Tue, Mar 09, 2010 at 07:56:07PM +0100, Thomas Bächler wrote:
> 
> Signed-off-by: Thomas Bächler <thomas@archlinux.org>
> ---
> This patch was made by trial-and-error, I copied the byte0 and
> mask0 value from another model, tried different flags settings
> and it seems to work. I have no idea if there might be side-
> effects due to incorrect settings. Please tell me if I can do
> anything to verify or correct these values.
> 
>  drivers/input/mouse/alps.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> index f93c2c0..f6dad83 100644
> --- a/drivers/input/mouse/alps.c
> +++ b/drivers/input/mouse/alps.c
> @@ -63,6 +63,8 @@ static const struct alps_model_info alps_model_data[] = {
>  	{ { 0x62, 0x02, 0x14 }, 0xcf, 0xcf,
>  		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },
>  	{ { 0x73, 0x02, 0x50 }, 0xcf, 0xcf, ALPS_FOUR_BUTTONS },	  /* Dell Vostro 1400 */
> +	{ { 0x52, 0x01, 0x14 }, 0xff, 0xff,
> +		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },	  /* Toshiba Tecra A11-11L */
>  };
>  

Looking at the picture it appears to have a touchpad only, not a
touchpad/trackpoint combo. So I am wondering if ALPS_DUALPOINT and
ALPS_PS2_INTERLEAVED flags are needed here. What happens if you remove
them? Also, does it have external PS/2 post?

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] input: alps: Add support for the touchpad of the Toshiba Tecra A11-11L

[Thomas Bächler]

[-- Attachment #1: Type: text/plain, Size: 1945 bytes --]

Am 09.03.2010 20:01, schrieb Dmitry Torokhov:
> Hi Thomas,
> 
> On Tue, Mar 09, 2010 at 07:56:07PM +0100, Thomas Bächler wrote:
>>
>> Signed-off-by: Thomas Bächler <thomas@archlinux.org>
>> ---
>> This patch was made by trial-and-error, I copied the byte0 and
>> mask0 value from another model, tried different flags settings
>> and it seems to work. I have no idea if there might be side-
>> effects due to incorrect settings. Please tell me if I can do
>> anything to verify or correct these values.
>>
>>  drivers/input/mouse/alps.c |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
>> index f93c2c0..f6dad83 100644
>> --- a/drivers/input/mouse/alps.c
>> +++ b/drivers/input/mouse/alps.c
>> @@ -63,6 +63,8 @@ static const struct alps_model_info alps_model_data[] = {
>>  	{ { 0x62, 0x02, 0x14 }, 0xcf, 0xcf,
>>  		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },
>>  	{ { 0x73, 0x02, 0x50 }, 0xcf, 0xcf, ALPS_FOUR_BUTTONS },	  /* Dell Vostro 1400 */
>> +	{ { 0x52, 0x01, 0x14 }, 0xff, 0xff,
>> +		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },	  /* Toshiba Tecra A11-11L */
>>  };
>>  
> 
> Looking at the picture it appears to have a touchpad only, not a
> touchpad/trackpoint combo. So I am wondering if ALPS_DUALPOINT and
> ALPS_PS2_INTERLEAVED flags are needed here. What happens if you remove
> them? Also, does it have external PS/2 post?

The model I have here does have a trackpoint, thus I put ALPS_DUALPOINT
in. Also, I had problems without ALPS_PS2_INTERLEAVED ([...] lost sync
at byte 1). I did not try without ALPS_PASS though, only with.

The device does not seem to have an external PS/2 port, but there is a
connector for a docking station (which I don't own).

I am more concerned about the two 0xff values here, because they are
actually guesses.

Thanks for the quick response.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

Re: [PATCH] input: alps: Add support for the touchpad of the Toshiba Tecra A11-11L

[Dmitry Torokhov]

On Tue, Mar 09, 2010 at 08:17:02PM +0100, Thomas Bächler wrote:
> Am 09.03.2010 20:01, schrieb Dmitry Torokhov:
> > Hi Thomas,
> > 
> > On Tue, Mar 09, 2010 at 07:56:07PM +0100, Thomas Bächler wrote:
> >>
> >> Signed-off-by: Thomas Bächler <thomas@archlinux.org>
> >> ---
> >> This patch was made by trial-and-error, I copied the byte0 and
> >> mask0 value from another model, tried different flags settings
> >> and it seems to work. I have no idea if there might be side-
> >> effects due to incorrect settings. Please tell me if I can do
> >> anything to verify or correct these values.
> >>
> >>  drivers/input/mouse/alps.c |    2 ++
> >>  1 files changed, 2 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> >> index f93c2c0..f6dad83 100644
> >> --- a/drivers/input/mouse/alps.c
> >> +++ b/drivers/input/mouse/alps.c
> >> @@ -63,6 +63,8 @@ static const struct alps_model_info alps_model_data[] = {
> >>  	{ { 0x62, 0x02, 0x14 }, 0xcf, 0xcf,
> >>  		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },
> >>  	{ { 0x73, 0x02, 0x50 }, 0xcf, 0xcf, ALPS_FOUR_BUTTONS },	  /* Dell Vostro 1400 */
> >> +	{ { 0x52, 0x01, 0x14 }, 0xff, 0xff,
> >> +		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },	  /* Toshiba Tecra A11-11L */
> >>  };
> >>  
> > 
> > Looking at the picture it appears to have a touchpad only, not a
> > touchpad/trackpoint combo. So I am wondering if ALPS_DUALPOINT and
> > ALPS_PS2_INTERLEAVED flags are needed here. What happens if you remove
> > them? Also, does it have external PS/2 post?
> 
> The model I have here does have a trackpoint, thus I put ALPS_DUALPOINT
> in. Also, I had problems without ALPS_PS2_INTERLEAVED ([...] lost sync
> at byte 1). I did not try without ALPS_PASS though, only with.
> 

No, ALPS_PASS is OK - you would notice right away if you didn't need it
- the device would not switch to absolute mode.

> The device does not seem to have an external PS/2 port, but there is a
> connector for a docking station (which I don't own).
>

Ah, I see.
 
> I am more concerned about the two 0xff values here, because they are
> actually guesses.
> 

If you do not see it loosing sync as you workign it then you selected
proper byte0 and mask.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] input: alps: Add support for the touchpad of the Toshiba Tecra A11-11L

[Thomas Bächler]

[-- Attachment #1: Type: text/plain, Size: 905 bytes --]

Am 09.03.2010 20:26, schrieb Dmitry Torokhov:
>> The model I have here does have a trackpoint, thus I put ALPS_DUALPOINT
>> in. Also, I had problems without ALPS_PS2_INTERLEAVED ([...] lost sync
>> at byte 1). I did not try without ALPS_PASS though, only with.
>>
> 
> No, ALPS_PASS is OK - you would notice right away if you didn't need it
> - the device would not switch to absolute mode.
> 
>> The device does not seem to have an external PS/2 port, but there is a
>> connector for a docking station (which I don't own).
>>
> 
> Ah, I see.
>  
>> I am more concerned about the two 0xff values here, because they are
>> actually guesses.
>>
> 
> If you do not see it loosing sync as you workign it then you selected
> proper byte0 and mask.

Good. In this case I guess you can apply the patch as it is. After
applying this, would you mind sending this to linux-stable as well?


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]