From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Oliver Neukum <oliver@neukum.org>
Cc: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
John Kacur <jkacur@gmail.com>,
jkosina@suse.cz
Subject: Re: [PATCH 2/3] input: use input_mutex instead of BKL when opening input device
Date: Tue, 9 Mar 2010 22:56:38 -0800 [thread overview]
Message-ID: <201003092256.39223.dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <201003100749.20723.oliver@neukum.org>
On Tuesday 09 March 2010 10:49:20 pm Oliver Neukum wrote:
> Am Mittwoch, 10. März 2010 07:20:15 schrieb Dmitry Torokhov:
> > > I was willing to let the open call go unprotected. But ended up
> > > checking that the three callees were fine (they do not call any of the
> > > other functions that take the mutex).
> > >
> > > Since the fops_put/fops_get do protect that section from the handler
> > > removal and I can't think of any other race right now, I think your
> > > version is really better.
> > >
> > > Acked-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
> >
> > OK, applied 2 Thadeu's patches and one Arnd's.
>
> Jiri,
>
> it is possible that this requires a change in usbhid as it uses BKL.
> Do you remember?
>
No, different layer altogether.
--
Dmitry
next prev parent reply other threads:[~2010-03-10 6:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 19:19 [PATCH 1/3] input: remove BKL from mousedev Thadeu Lima de Souza Cascardo
2010-03-09 19:19 ` [PATCH 2/3] input: use input_mutex instead of BKL when opening input device Thadeu Lima de Souza Cascardo
2010-03-09 19:19 ` [PATCH 3/3] input: remove BKL from serio_raw Thadeu Lima de Souza Cascardo
2010-03-09 20:06 ` Arnd Bergmann
2010-03-09 20:06 ` [PATCH 2/3] input: use input_mutex instead of BKL when opening input device Arnd Bergmann
2010-03-09 20:12 ` Arnd Bergmann
2010-03-09 20:59 ` Thadeu Lima de Souza Cascardo
2010-03-10 6:20 ` Dmitry Torokhov
2010-03-10 6:49 ` Oliver Neukum
2010-03-10 6:56 ` Dmitry Torokhov [this message]
2010-03-09 20:05 ` [PATCH 1/3] input: remove BKL from mousedev Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003092256.39223.dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=arnd@arndb.de \
--cc=cascardo@holoscopio.com \
--cc=jkacur@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).