From: akpm@linux-foundation.org
To: dtor@mail.ru
Cc: linux-input@vger.kernel.org, akpm@linux-foundation.org,
rydberg@euromail.se
Subject: [patch 1/1] input: bcm5974: retract efi-broken suspend_resume
Date: Thu, 11 Mar 2010 14:04:58 -0800 [thread overview]
Message-ID: <201003112204.o2BM4wYm013275@imap1.linux-foundation.org> (raw)
From: "Henrik Rydberg" <rydberg@euromail.se>
With the recent system-wide improvements on suspend/resume and EFI booting
the suspend_resume method of the bcm5974 has broken. When waking up from
the S3 state on the MacBookAir, the trackpad is found in a yet unknown
state, unable to switch to the proper multitouch mode. The result is a
frozen touchpad, and a flood of errors of the kind
bcm5974: bad trackpad package, length: 8.
This patch retracts the reset_resume method altogether, falling back on
the generic unbind/rebind functionality of the usb layer until further
investigations can be made as how to reset the device when booting from
efi.
Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
Cc: Dmitry Torokhov <dtor@mail.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/input/mouse/bcm5974.c | 1 -
1 file changed, 1 deletion(-)
diff -puN drivers/input/mouse/bcm5974.c~input-bcm5974-retract-efi-broken-suspend_resume drivers/input/mouse/bcm5974.c
--- a/drivers/input/mouse/bcm5974.c~input-bcm5974-retract-efi-broken-suspend_resume
+++ a/drivers/input/mouse/bcm5974.c
@@ -803,7 +803,6 @@ static struct usb_driver bcm5974_driver
.disconnect = bcm5974_disconnect,
.suspend = bcm5974_suspend,
.resume = bcm5974_resume,
- .reset_resume = bcm5974_resume,
.id_table = bcm5974_table,
.supports_autosuspend = 1,
};
_
next reply other threads:[~2010-03-11 22:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 22:04 akpm [this message]
2010-03-13 8:35 ` [patch 1/1] input: bcm5974: retract efi-broken suspend_resume Dmitry Torokhov
2010-03-14 9:51 ` Henrik Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003112204.o2BM4wYm013275@imap1.linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dtor@mail.ru \
--cc=linux-input@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).