[patch 1/1] input: bcm5974: retract efi-broken suspend_resume

[patch 1/1] input: bcm5974: retract efi-broken suspend_resume

[akpm]

From: "Henrik Rydberg" <rydberg@euromail.se>

With the recent system-wide improvements on suspend/resume and EFI booting
the suspend_resume method of the bcm5974 has broken.  When waking up from
the S3 state on the MacBookAir, the trackpad is found in a yet unknown
state, unable to switch to the proper multitouch mode.  The result is a
frozen touchpad, and a flood of errors of the kind

bcm5974: bad trackpad package, length: 8.

This patch retracts the reset_resume method altogether, falling back on
the generic unbind/rebind functionality of the usb layer until further
investigations can be made as how to reset the device when booting from
efi.

Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
Cc: Dmitry Torokhov <dtor@mail.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/input/mouse/bcm5974.c |    1 -
 1 file changed, 1 deletion(-)

diff -puN drivers/input/mouse/bcm5974.c~input-bcm5974-retract-efi-broken-suspend_resume drivers/input/mouse/bcm5974.c
--- a/drivers/input/mouse/bcm5974.c~input-bcm5974-retract-efi-broken-suspend_resume
+++ a/drivers/input/mouse/bcm5974.c
@@ -803,7 +803,6 @@ static struct usb_driver bcm5974_driver 
 	.disconnect		= bcm5974_disconnect,
 	.suspend		= bcm5974_suspend,
 	.resume			= bcm5974_resume,
-	.reset_resume		= bcm5974_resume,
 	.id_table		= bcm5974_table,
 	.supports_autosuspend	= 1,
 };
_

Re: [patch 1/1] input: bcm5974: retract efi-broken suspend_resume

[Dmitry Torokhov]

Henrik,

On Thu, Mar 11, 2010 at 02:04:58PM -0800, akpm@linux-foundation.org wrote:
> From: "Henrik Rydberg" <rydberg@euromail.se>
> 
> With the recent system-wide improvements on suspend/resume and EFI booting
> the suspend_resume method of the bcm5974 has broken.  When waking up from
> the S3 state on the MacBookAir, the trackpad is found in a yet unknown
> state, unable to switch to the proper multitouch mode.  The result is a
> frozen touchpad, and a flood of errors of the kind
> 
> bcm5974: bad trackpad package, length: 8.
> 
> This patch retracts the reset_resume method altogether, falling back on
> the generic unbind/rebind functionality of the usb layer until further
> investigations can be made as how to reset the device when booting from
> efi.

Is the driver still broken on EFI without this patch? I was hoping if I
ignore the patch long enough EFI will get fixed ;)

Thanks.

-- 
Dmitry

Re: [patch 1/1] input: bcm5974: retract efi-broken suspend_resume

[Henrik Rydberg]

Dmitry Torokhov wrote:
> Henrik,
> 
> On Thu, Mar 11, 2010 at 02:04:58PM -0800, akpm@linux-foundation.org wrote:
>> From: "Henrik Rydberg" <rydberg@euromail.se>
>>
>> With the recent system-wide improvements on suspend/resume and EFI booting
>> the suspend_resume method of the bcm5974 has broken.  When waking up from
>> the S3 state on the MacBookAir, the trackpad is found in a yet unknown
>> state, unable to switch to the proper multitouch mode.  The result is a
>> frozen touchpad, and a flood of errors of the kind
>>
>> bcm5974: bad trackpad package, length: 8.
>>
>> This patch retracts the reset_resume method altogether, falling back on
>> the generic unbind/rebind functionality of the usb layer until further
>> investigations can be made as how to reset the device when booting from
>> efi.
> 
> Is the driver still broken on EFI without this patch? I was hoping if I
> ignore the patch long enough EFI will get fixed ;)
> 
> Thanks.
> 

The problem persists in all grub-efi flavors of version 1.97. I have not been
able to test later versions.

Henrik