Re: [RFC/RFT 3/5] USB: usbtouch: Prevent possible deadlock

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

Hi Oliver,

On Fri, Mar 12, 2010 at 03:42:53PM +0100, Oliver Neukum wrote:
> From 5e4fc75d1031ca1c621c0f85cf1e903ffd8fb758 Mon Sep 17 00:00:00 2001
> From: Oliver Neukum <oliver@neukum.org>
> Date: Thu, 11 Mar 2010 15:06:51 +0100
> Subject: [PATCH 3/5] USB: usbtouch: Prevent possible deadlock
> 
> For autosuspend memory in suspend/resume must be allocated with
> GFP_NOIO.

I'd prefer if this change was folded into previous patch - there was no
deadlock condition before you added reset_resume.

> @@ -806,19 +806,19 @@ static int nexio_init(struct usbtouch_usb *usbtouch)
>  	/* prepare ACK URB */
>  	ret = -ENOMEM;
>  
> -	usbtouch->priv = kmalloc(sizeof(struct nexio_priv), GFP_KERNEL);
> +	usbtouch->priv = kmalloc(sizeof(struct nexio_priv), GFP_NOIO);
>  	if (!usbtouch->priv)
>  		goto out_buf;
>  

Remind me, how does ->exit() gets called in case of reset_resume?
Otherwise it looks like ne are leaking memory...

-- 
Dmitry