From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Yong Wang <yong.y.wang@linux.intel.com>
Cc: Corentin Chary <corentincj@iksaif.net>,
platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] eeepc-wmi: new driver for WMI based hotkeys on Eee PC laptops
Date: Fri, 19 Mar 2010 15:23:23 +0000 [thread overview]
Message-ID: <20100319152323.GA30456@srcf.ucam.org> (raw)
In-Reply-To: <20100319151054.GA30664@ywang-moblin2.bj.intel.com>
On Fri, Mar 19, 2010 at 11:10:54PM +0800, Yong Wang wrote:
> On Fri, Mar 19, 2010 at 01:59:29PM +0000, Matthew Garrett wrote:
> >
> > This probably ought to use the new sparse keymap code. I know that there
> > are drivers that are currently in the tree that don't, but it's probably
> > preferable to avoid adding new ones.
> >
>
> OK, will take a look at the new interface and revise accordingly.
Wonderful, thanks.
> > > + if (code >= NOTIFY_BRNUP_MIN && code <= NOTIFY_BRNUP_MAX)
> > > + code = NOTIFY_BRNUP_MIN;
> > > + else if (code >= NOTIFY_BRNDOWN_MIN && code <= NOTIFY_BRNDOWN_MAX)
> > > + code = NOTIFY_BRNDOWN_MIN;
> >
> > Do the brightness keys just send notifications, or do they actually
> > change the brightness? If they actually change the brightness, we
> > shouldn't send input events.
> >
>
> Yes, hardware and bios change brightness by themselves without software intervention
> on my Eee PC 1005 when pressing the hotkeys.
Ok. In that case, you shouldn't send input events. Once backlight
control is implemented in the eee-wmi driver you can send notifications
via that instead.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-03-19 15:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100319133924.GA30427@ywang-moblin2.bj.intel.com>
2010-03-19 13:59 ` [PATCH] eeepc-wmi: new driver for WMI based hotkeys on Eee PC laptops Matthew Garrett
2010-03-19 15:10 ` Yong Wang
2010-03-19 15:23 ` Matthew Garrett [this message]
2010-03-19 15:21 ` Yong Wang
2010-03-20 0:55 ` Yong Wang
2010-03-20 12:20 ` cascardo
2010-03-20 12:24 ` Yong Wang
2010-03-20 17:21 ` Corentin Chary
2010-03-21 0:59 ` Yong Wang
2010-03-21 13:14 ` Corentin Chary
2010-03-21 13:35 ` Yong Wang
2010-03-21 13:55 ` Corentin Chary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100319152323.GA30456@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=corentincj@iksaif.net \
--cc=linux-input@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=yong.y.wang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).