From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH] eeepc-wmi: new driver for WMI based hotkeys on Eee PC laptops Date: Fri, 19 Mar 2010 15:23:23 +0000 Message-ID: <20100319152323.GA30456@srcf.ucam.org> References: <20100319133924.GA30427@ywang-moblin2.bj.intel.com> <20100319135929.GA29027@srcf.ucam.org> <20100319151054.GA30664@ywang-moblin2.bj.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cavan.codon.org.uk ([93.93.128.6]:53277 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751579Ab0CSPX0 (ORCPT ); Fri, 19 Mar 2010 11:23:26 -0400 Content-Disposition: inline In-Reply-To: <20100319151054.GA30664@ywang-moblin2.bj.intel.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Yong Wang Cc: Corentin Chary , platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org On Fri, Mar 19, 2010 at 11:10:54PM +0800, Yong Wang wrote: > On Fri, Mar 19, 2010 at 01:59:29PM +0000, Matthew Garrett wrote: > > > > This probably ought to use the new sparse keymap code. I know that there > > are drivers that are currently in the tree that don't, but it's probably > > preferable to avoid adding new ones. > > > > OK, will take a look at the new interface and revise accordingly. Wonderful, thanks. > > > + if (code >= NOTIFY_BRNUP_MIN && code <= NOTIFY_BRNUP_MAX) > > > + code = NOTIFY_BRNUP_MIN; > > > + else if (code >= NOTIFY_BRNDOWN_MIN && code <= NOTIFY_BRNDOWN_MAX) > > > + code = NOTIFY_BRNDOWN_MIN; > > > > Do the brightness keys just send notifications, or do they actually > > change the brightness? If they actually change the brightness, we > > shouldn't send input events. > > > > Yes, hardware and bios change brightness by themselves without software intervention > on my Eee PC 1005 when pressing the hotkeys. Ok. In that case, you shouldn't send input events. Once backlight control is implemented in the eee-wmi driver you can send notifications via that instead. -- Matthew Garrett | mjg59@srcf.ucam.org