Merge plans for Staging Synaptics Touchscreen Driver

Merge plans for Staging Synaptics Touchscreen Driver

[Hemanth V]

Hi All,

Are there any plans to merge the synaptics touchscreen driver
(drivers/staging/dream/synaptics_i2c_rmi.c) to
drivers/input/touchscreen. We are interested in the same
since OMAP3 based Zoom boards use this touchscreen.

Pl add (if required) below tested by for the staging driver.

Tested-By: Hemanth V <hemanthv@ti.com>

Thanks
Hemanth

RE: Merge plans for Staging Synaptics Touchscreen Driver

[Aguirre, Sergio]

Hi Hemanth,

> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of V, Hemanth
> Sent: Tuesday, March 23, 2010 4:29 AM
> To: pavel@ucw.cz; linux-input@vger.kernel.org
> Cc: linux-omap@vger.kernel.org
> Subject: Merge plans for Staging Synaptics Touchscreen Driver
> 
> Hi All,
> 
> Are there any plans to merge the synaptics touchscreen driver
> (drivers/staging/dream/synaptics_i2c_rmi.c) to
> drivers/input/touchscreen. We are interested in the same
> since OMAP3 based Zoom boards use this touchscreen.

Can you please elaborate on the specific Synaptics touchscreen chip you're attempting to drive?

Unless there's only one synaptic chip that exists...

Regards,
Sergio

> 
> Pl add (if required) below tested by for the staging driver.
> 
> Tested-By: Hemanth V <hemanthv@ti.com>
> 
> Thanks
> Hemanth
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: Merge plans for Staging Synaptics Touchscreen Driver

[Hemanth V]

> Hi Hemanth,
>
>> -----Original Message-----
>> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
>> owner@vger.kernel.org] On Behalf Of V, Hemanth
>> Sent: Tuesday, March 23, 2010 4:29 AM
>> To: pavel@ucw.cz; linux-input@vger.kernel.org
>> Cc: linux-omap@vger.kernel.org
>> Subject: Merge plans for Staging Synaptics Touchscreen Driver
>>
>> Hi All,
>>
>> Are there any plans to merge the synaptics touchscreen driver
>> (drivers/staging/dream/synaptics_i2c_rmi.c) to
>> drivers/input/touchscreen. We are interested in the same
>> since OMAP3 based Zoom boards use this touchscreen.
>
> Can you please elaborate on the specific Synaptics touchscreen chip you're attempting to drive?
>

Sergio,

The current driver available in staging directory is for
Synaptics RMI3 chip 511-000099-01F

Thanks
Hemanth

Re: Merge plans for Staging Synaptics Touchscreen Driver

[Pavel Machek]

Hi!

> Are there any plans to merge the synaptics touchscreen driver
> (drivers/staging/dream/synaptics_i2c_rmi.c) to
> drivers/input/touchscreen. We are interested in the same
> since OMAP3 based Zoom boards use this touchscreen.

Plans are, but day job interferes with them.

> Pl add (if required) below tested by for the staging driver.

Its not as easy.

So... 

1) are you able to use driver in staging?

at minimum, non-standard multitouch support needs to be removed before
merging to input. Do you have time to help?

Plus it would be good to investigate possibility of using threaded
interrupt support -- look through mail archives.
								Pavel 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: Merge plans for Staging Synaptics Touchscreen Driver

[Hemanth V]

> Hi!
>
>> Are there any plans to merge the synaptics touchscreen driver
>> (drivers/staging/dream/synaptics_i2c_rmi.c) to
>> drivers/input/touchscreen. We are interested in the same
>> since OMAP3 based Zoom boards use this touchscreen.
>
> Plans are, but day job interferes with them.
>
>> Pl add (if required) below tested by for the staging driver.

>
> 1) are you able to use driver in staging?

Yes I am able to use staging driver for single
touch events.

>
> at minimum, non-standard multitouch support needs to be removed before
> merging to input. Do you have time to help?

Could you review the below patch.

Thanks
Hemanth

---

Remove non-standard multi touch support.

Signed-off-by: Hemanth V <hemanthv@ti.com>

diff --git a/drivers/staging/dream/synaptics_i2c_rmi.c b/drivers/staging/dream/synaptics_i2c_rmi.c
index 4de6bc9..34449ad 100644
--- a/drivers/staging/dream/synaptics_i2c_rmi.c
+++ b/drivers/staging/dream/synaptics_i2c_rmi.c
@@ -150,14 +150,6 @@ static void decode_report(struct synaptics_ts_data *ts, u8 *buf)
 		input_report_abs(ts->input_dev, ABS_Y, pos[0][1]);
 	}
 	input_report_abs(ts->input_dev, ABS_PRESSURE, z);
-	input_report_abs(ts->input_dev, ABS_TOOL_WIDTH, w);
-	input_report_key(ts->input_dev, BTN_TOUCH, finger);
-	finger2_pressed = finger > 1 && finger != 7;
-	input_report_key(ts->input_dev, BTN_2, finger2_pressed);
-	if (finger2_pressed) {
-		input_report_abs(ts->input_dev, ABS_HAT0X, pos[1][0]);
-		input_report_abs(ts->input_dev, ABS_HAT0Y, pos[1][1]);
-	}
 	input_sync(ts->input_dev);
 }

Re: Merge plans for Staging Synaptics Touchscreen Driver

[Hemanth V]

>> Hi!
>>
>>> Are there any plans to merge the synaptics touchscreen driver
>>> (drivers/staging/dream/synaptics_i2c_rmi.c) to
>>> drivers/input/touchscreen. We are interested in the same
>>> since OMAP3 based Zoom boards use this touchscreen.
>>
>> Plans are, but day job interferes with them.
>>
>>> Pl add (if required) below tested by for the staging driver.
>
>>
>> 1) are you able to use driver in staging?
>
> Yes I am able to use staging driver for single
> touch events.
>
>>
>> at minimum, non-standard multitouch support needs to be removed before
>> merging to input. Do you have time to help?
>
> Could you review the below patch.

Forgot to remove unused variables in earlier patch, here's
the updated one.


---

Remove non-standard multi touch support.

Signed-off-by: Hemanth V <hemanthv@ti.com>

diff --git a/drivers/staging/dream/synaptics_i2c_rmi.c b/drivers/staging/dream/synaptics_i2c_rmi.c
index 4de6bc9..f3bc7d6 100644
--- a/drivers/staging/dream/synaptics_i2c_rmi.c
+++ b/drivers/staging/dream/synaptics_i2c_rmi.c
@@ -108,9 +108,6 @@ static void decode_report(struct synaptics_ts_data *ts, u8 *buf)
 	int f, a;
 	int base = 2;
 	int z = buf[1];
-	int w = buf[0] >> 4;
-	int finger = buf[0] & 7;
-	int finger2_pressed;

 	for (f = 0; f < 2; f++) {
 		u32 flip_flag = SYNAPTICS_FLIP_X;
@@ -150,14 +147,6 @@ static void decode_report(struct synaptics_ts_data *ts, u8 *buf)
 		input_report_abs(ts->input_dev, ABS_Y, pos[0][1]);
 	}
 	input_report_abs(ts->input_dev, ABS_PRESSURE, z);
-	input_report_abs(ts->input_dev, ABS_TOOL_WIDTH, w);
-	input_report_key(ts->input_dev, BTN_TOUCH, finger);
-	finger2_pressed = finger > 1 && finger != 7;
-	input_report_key(ts->input_dev, BTN_2, finger2_pressed);
-	if (finger2_pressed) {
-		input_report_abs(ts->input_dev, ABS_HAT0X, pos[1][0]);
-		input_report_abs(ts->input_dev, ABS_HAT0Y, pos[1][1]);
-	}
 	input_sync(ts->input_dev);
 }

Re: Merge plans for Staging Synaptics Touchscreen Driver

[Pavel Machek]

Hi!

> >>> Pl add (if required) below tested by for the staging driver.
> >
> >>
> >> 1) are you able to use driver in staging?
> >
> > Yes I am able to use staging driver for single
> > touch events.

Good.

> >> at minimum, non-standard multitouch support needs to be removed before
> >> merging to input. Do you have time to help?
> >
> > Could you review the below patch.
> 
> Forgot to remove unused variables in earlier patch, here's
> the updated one.

Thanks, seems ok.

> Remove non-standard multi touch support.
> 
> Signed-off-by: Hemanth V <hemanthv@ti.com>

ACK.

Now... you probably want to send the patch to Greg. And then, I guess
you could take the patch from staging, and ask for another round of
review on linux-input.

If you could figure out if threaded interrupts can be used for this
driver, that would be welcome bonus.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html