From mboxrd@z Thu Jan 1 00:00:00 1970 From: David =?iso-8859-1?Q?H=E4rdeman?= Subject: Re: [PATCH 5/8] ir-core: convert mantis from ir-functions.c Date: Mon, 19 Apr 2010 11:58:18 +0200 Message-ID: <20100419095818.GA3055@hardeman.nu> References: <20100415214520.14142.56114.stgit@localhost.localdomain> <20100415214620.14142.19939.stgit@localhost.localdomain> <20100416205638.GA2873@hardeman.nu> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from 1-1-12-13a.han.sth.bostream.se ([82.182.30.168]:57991 "EHLO palpatine.hardeman.nu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752076Ab0DSJ6a (ORCPT ); Mon, 19 Apr 2010 05:58:30 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Manu Abraham Cc: mchehab@redhat.com, linux-media@vger.kernel.org, linux-input@vger.kernel.org On Sat, Apr 17, 2010 at 01:27:05AM +0400, Manu Abraham wrote: > On Sat, Apr 17, 2010 at 12:56 AM, David H=E4rdeman wrote: > > On Fri, Apr 16, 2010 at 03:17:35AM +0400, Manu Abraham wrote: > >> On Fri, Apr 16, 2010 at 1:46 AM, David H=E4rdeman wrote: > >> > Convert drivers/media/dvb/mantis/mantis_input.c to not use ir-fu= nctions.c > >> > (The driver is anyway not complete enough to actually use the su= bsystem yet). > >> > >> Huh ? I don't follow what you imply here .. > >> > > > > The mantis_input.c file seems to be a skeleton as far as I could > > tell...not actually in use yet. Or am I mistaken? >=20 > Only the input related parts of the IR stuff is there in > mantis_input.c, the hardware handling is done by mantis_uart.c/h. > There is a small bit which has not gone upstream yet, which is > pending; > http://jusst.de/hg/mantis-v4l-dvb/rev/ad8b00c9edc2 >=20 Yes, and that patch includes actually calling mantis_input_init(), whic= h=20 wasn't called previously, so mantis_input.c wasn't actually in use. Anyways, my patch still applies (or the principle at least) - use the=20 functionality of ir-core and not ir-functions.c (which is going away). And on a related note, the above patch adds keytables with entries like= =20 KEY_0, they should probably be KEY_NUMERIC_* instead. --=20 David H=E4rdeman -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html