From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] Input: add appleir USB driver Date: Wed, 21 Apr 2010 13:09:41 -0700 Message-ID: <20100421200941.GA10671@core.coreip.homeip.net> References: <1271434792.2045.5.camel@localhost.localdomain> <20100417081212.GA19866@core.coreip.homeip.net> <1271669507.17421.39.camel@localhost.localdomain> <1271672080.17421.91.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pv0-f174.google.com ([74.125.83.174]:60801 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755658Ab0DUUJr (ORCPT ); Wed, 21 Apr 2010 16:09:47 -0400 Received: by pvg13 with SMTP id 13so1137968pvg.19 for ; Wed, 21 Apr 2010 13:09:47 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Jiri Kosina Cc: Bastien Nocera , linux-input@vger.kernel.org On Mon, Apr 19, 2010 at 01:08:57PM +0200, Jiri Kosina wrote: > On Mon, 19 Apr 2010, Bastien Nocera wrote: > > > > > > > > Signed-off-by: Bastien Nocera > > > > > > > --- > > > > > > > Documentation/input/appleir.txt | 45 ++++ > > > > > > > drivers/hid/hid-apple.c | 4 - > > > > > > > drivers/hid/hid-core.c | 5 +- > > > > > > > drivers/hid/hid-ids.h | 1 + > > > > > > > > > > > > HID pieces need to go through Jiri or he needs to ack them to go through > > > > > > my tree... > > > > > > > > > > Please feel free to put > > > > > > > > > > Signed-off-by: Jiri Kosina > > > > > > > > > > on the blakclist changes in drivers/hid once you merge the > > > > > standalone appleir driver from Bastien. > > > > > > > > Any comments on the additional quirks necessary to get lirc working? > > > > > > Ouch, I thought that we have discussed previously that I am basically fine > > > with adding those two quirks, but I haven't seen any patch doing that > > > since then ... ? > > > > > > So I'd suggest you either remove that part from the appleir documentation > > > until this is implemented, or send me a patch adding those two flags. > > > > I sent it Friday with the subject: > > [PATCH] Add HID_QUIRK_HIDDEV_FORCE and HID_QUIRK_NO_IGNORE > > > > The patch was also sent to the input list: > > http://thread.gmane.org/gmane.linux.kernel.input/12176 > > Ah, now I see it. It somehow didn't reach my inbox, though your other > mails do, odd. > > Thanks, I will take it through my tree and queue it for next merge window > (if Dmitry is not going to push the driver even for current -rcs ... ?). > No, even though it is a new driver it is gettign kind of late. I am going to put it in my 'next' branch. -- Dmitry